third_party/WebKit/Source/core/page/CreateWindow.cpp - Issue 2798593002: Count how often we'd throw for invalid URLs in window.open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/CreateWindow.cpp

Issue 2798593002: Count how often we'd throw for invalid URLs in window.open (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/CreateWindow.cpp

diff --git a/third_party/WebKit/Source/core/page/CreateWindow.cpp b/third_party/WebKit/Source/core/page/CreateWindow.cpp

index f404b43ec4965b8fffcf1e6ce94c5d3f7100828c..203dcd3d2b99be096ed7920228708e63c9e285bc 100644

--- a/third_party/WebKit/Source/core/page/CreateWindow.cpp

+++ b/third_party/WebKit/Source/core/page/CreateWindow.cpp

@@ -186,6 +186,7 @@ DOMWindow* createWindow(const String& urlString,

? KURL(ParsedURLString, emptyString)

: firstFrame.document()->completeURL(urlString);

if (!completedURL.isEmpty() && !completedURL.isValid()) {

+ UseCounter::count(activeFrame, UseCounter::WindowOpenWithInvalidURL);

// Don't expose client code to invalid URLs.

callingWindow.printErrorMessage(

"Unable to open a window with invalid URL '" +