Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2798533002: [ES6 modules] ScriptModule::compile() exceptions are handled via isolate's MessageListener (Closed)

Created:
3 years, 8 months ago by kouhei (in TOK)
Modified:
3 years, 8 months ago
Reviewers:
haraken, yhirano, nhiroki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ES6 modules] ScriptModule::compile() exceptions are handled via isolate's MessageListener This CL removes a TODO comment and clarify that ScriptModule::compile errors are routed via isolate's MessageListener. Bonus: ScriptModule ctor w/o args is used to create null ScriptModule. BUG=594639 Review-Url: https://codereview.chromium.org/2798533002 Cr-Commit-Position: refs/heads/master@{#461684} Committed: https://chromium.googlesource.com/chromium/src/+/756f4ddeb12a503550c6409934a0a8ac80354276

Patch Set 1 #

Patch Set 2 : isnull #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptModule.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp View 1 2 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
kouhei (in TOK)
3 years, 8 months ago (2017-04-04 05:48:21 UTC) #2
haraken
LGTM
3 years, 8 months ago (2017-04-04 05:53:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798533002/1
3 years, 8 months ago (2017-04-04 05:55:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/422728)
3 years, 8 months ago (2017-04-04 07:13:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798533002/20001
3 years, 8 months ago (2017-04-04 10:19:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798533002/40001
3 years, 8 months ago (2017-04-04 10:22:45 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 11:44:43 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/756f4ddeb12a503550c6409934a0...

Powered by Google App Engine
This is Rietveld 408576698