third_party/WebKit/Source/bindings/core/v8/ScriptModule.h - Issue 2798533002: [ES6 modules] ScriptModule::compile() exceptions are handled via isolate's MessageListener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptModule.h

Issue 2798533002: [ES6 modules] ScriptModule::compile() exceptions are handled via isolate's MessageListener (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptModule.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h

index 5e4f81e8d6371d6d6720b1ce399a20229078c387..a7c0fa0771f9e3c45e7b1969144450ce2d878cb2 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h

@@ -37,7 +37,7 @@ class CORE_EXPORT ScriptModule final {

ScriptValue instantiate(ScriptState*);

void evaluate(ScriptState*);

- bool isNull() const { return m_module->isEmpty(); }

+ bool isNull() const { return !m_module || m_module->isEmpty(); }

private:

ScriptModule(v8::Isolate*, v8::Local<v8::Module>);

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp » ('j') | no next file with comments »