Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2798403002: Removed "host_whitelist" QUIC parameter from Cronet Tests (Closed)

Created:
3 years, 8 months ago by kapishnikov
Modified:
3 years, 8 months ago
Reviewers:
mgersh, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

"host_whitelist" QUIC parameter is deprecated starting from version 31 (see https://cs.chromium.org/chromium/src/net/http/http_stream_factory_impl_job_controller.cc?type=cs&q=%22The+QUIC+whitelist+is+not+needed+in+QUIC+versions+after+30.%22&l=913). Removed the parameter from the Cronet tests but kept it in the Cronet implementation since there still may be servers that speak QUIC prior 31. BUG=702412 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2798403002 Cr-Commit-Position: refs/heads/master@{#462621} Committed: https://chromium.googlesource.com/chromium/src/+/48296219d472221d30d3a8cc4d03317ee2dd2851

Patch Set 1 #

Total comments: 1

Patch Set 2 : Cleaned Cronet tests by removing "host_whitelist" deprecated QUIC parameter. #

Messages

Total messages: 20 (12 generated)
kapishnikov
A small test fix. PTAL.
3 years, 8 months ago (2017-04-06 18:13:22 UTC) #3
mgersh
lgtm
3 years, 8 months ago (2017-04-06 18:22:24 UTC) #6
xunjieli
On 2017/04/06 18:22:24, mgersh wrote: > lgtm deferring to Miriam :)
3 years, 8 months ago (2017-04-06 18:25:10 UTC) #7
xunjieli
https://codereview.chromium.org/2798403002/diff/1/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/QuicTest.java File components/cronet/android/test/smoketests/src/org/chromium/net/smoke/QuicTest.java (right): https://codereview.chromium.org/2798403002/diff/1/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/QuicTest.java#newcode46 components/cronet/android/test/smoketests/src/org/chromium/net/smoke/QuicTest.java:46: new JSONObject().put("delay_tcp_race", true).put("host_whitelist", url.getHost()); hmm.. if we didn't need ...
3 years, 8 months ago (2017-04-06 18:31:20 UTC) #8
kapishnikov
On 2017/04/06 18:31:20, xunjieli wrote: > https://codereview.chromium.org/2798403002/diff/1/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/QuicTest.java > File > components/cronet/android/test/smoketests/src/org/chromium/net/smoke/QuicTest.java > (right): > > ...
3 years, 8 months ago (2017-04-06 20:09:35 UTC) #12
xunjieli
On 2017/04/06 20:09:35, kapishnikov wrote: > On 2017/04/06 18:31:20, xunjieli wrote: > > > https://codereview.chromium.org/2798403002/diff/1/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/QuicTest.java ...
3 years, 8 months ago (2017-04-06 20:11:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798403002/20001
3 years, 8 months ago (2017-04-06 20:20:28 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 21:14:43 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/48296219d472221d30d3a8cc4d03...

Powered by Google App Engine
This is Rietveld 408576698