components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java - Issue 2798403002: Removed "host_whitelist" QUIC parameter from Cronet Tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

Issue 2798403002: Removed "host_whitelist" QUIC parameter from Cronet Tests (Closed)

Patch Set: Cleaned Cronet tests by removing "host_whitelist" deprecated QUIC parameter. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/QuicUploadTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

index ca8f6f74184279d26f30d611783832cb11143c1c..a0958c2b3500951947757928665ff40365c9d283 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

@@ -47,7 +47,6 @@ public class QuicTest extends CronetTestBase {

// TODO(mgersh): Enable connection migration once it works, see http://crbug.com/634910

JSONObject quicParams = new JSONObject()

.put("connection_options", "PACE,IW10,FOO,DEADBEEF")

- .put("host_whitelist", "test.example.com")

.put("max_server_configs_stored_in_properties", 2)

.put("delay_tcp_race", true)

.put("idle_connection_timeout_seconds", 300)

@@ -119,10 +118,8 @@ public class QuicTest extends CronetTestBase {

builder.setStoragePath(CronetTestFramework.getTestStorage(getContext()));

builder.enableHttpCache(CronetEngine.Builder.HTTP_CACHE_DISK, 1000 * 1024);

builder.enableQuic(true);

- JSONObject quicParams = new JSONObject().put("host_whitelist", "test.example.com");

JSONObject hostResolverParams = CronetTestUtil.generateHostResolverRules();

JSONObject experimentalOptions = new JSONObject()

- .put("QUIC", quicParams)

.put("HostResolverRules", hostResolverParams);

builder.setExperimentalOptions(experimentalOptions.toString());

CronetTestUtil.setMockCertVerifierForTesting(