Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2798393006:
Add CHECK in PingLoaderImpl's destructor (Closed)
DescriptionAdd CHECK in PingLoaderImpl's destructor
BUG=662769
R=yhirano@chromium.org
Review-Url: https://codereview.chromium.org/2798393006
Cr-Commit-Position: refs/heads/master@{#462821}
Committed: https://chromium.googlesource.com/chromium/src/+/a0b150ffc2dcafc7b302da312523e6c7ff80e8d6
Patch Set 1 : . #Patch Set 2 : CHECK #Patch Set 3 : comment #Messages
Total messages: 19 (13 generated)
The CQ bit was checked by kinuko@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I suspect this could be the cause? PTL
On 2017/04/07 07:55:13, kinuko wrote: > I suspect this could be the cause? PTL Does this CL change anything? A PingLoader will be kept alive as long as m_keepAlive is set, and dispose is the only point it is unset.
Description was changed from ========== Call PingLoaderImpl::dispose() in prefinalizer BUG=662769 R=yhirano@chromium.org ========== to ========== Add CHECK in PingLoaderImpl's destructor BUG=662769 R=yhirano@chromium.org ==========
The CQ bit was checked by kinuko@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by kinuko@chromium.org
The CQ bit was checked by kinuko@chromium.org to run a CQ dry run
On 2017/04/07 08:02:54, yhirano wrote: > On 2017/04/07 07:55:13, kinuko wrote: > > I suspect this could be the cause? PTL > > Does this CL change anything? A PingLoader will be kept alive as long as > m_keepAlive is set, and dispose is the only point it is unset. True... and m_loader is set only in ctor. I changed the if in dtor to CHECK to confirm. PTAL?
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by kinuko@chromium.org
The CQ bit was checked by kinuko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491553111593230,
"parent_rev": "5a0135d881a3974cb6b1543c27d3ed6c11e7721e", "commit_rev":
"a0b150ffc2dcafc7b302da312523e6c7ff80e8d6"}
Message was sent while issue was closed.
Description was changed from ========== Add CHECK in PingLoaderImpl's destructor BUG=662769 R=yhirano@chromium.org ========== to ========== Add CHECK in PingLoaderImpl's destructor BUG=662769 R=yhirano@chromium.org Review-Url: https://codereview.chromium.org/2798393006 Cr-Commit-Position: refs/heads/master@{#462821} Committed: https://chromium.googlesource.com/chromium/src/+/a0b150ffc2dcafc7b302da312523... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/a0b150ffc2dcafc7b302da312523... |
