third_party/WebKit/Source/core/loader/PingLoader.cpp - Issue 2798393006: Add CHECK in PingLoaderImpl's destructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/PingLoader.cpp

Issue 2798393006: Add CHECK in PingLoaderImpl's destructor (Closed)

Patch Set: comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/PingLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/PingLoader.cpp b/third_party/WebKit/Source/core/loader/PingLoader.cpp

index 01744876dd14b1d5f77e5b62281bab1862fc4e3a..2a2af332796772fa06540e9cc3f16a25d08506dc 100644

--- a/third_party/WebKit/Source/core/loader/PingLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/PingLoader.cpp

@@ -281,8 +281,8 @@ PingLoaderImpl::PingLoaderImpl(LocalFrame* frame,

}

PingLoaderImpl::~PingLoaderImpl() {

- if (m_loader)

- m_loader->cancel();

+ // TODO(kinuko): Turn this to DCHECK once crbug.com/662769 is resolved.

+ CHECK(!m_loader);

}

void PingLoaderImpl::dispose() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »