Avoid duplicate functions/code in core/editing: DirectionalSelection

Avoid duplicate functions/code in core/editing: DirectionalSelection

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

shouldAlwaysUseDirectionalSelection is a common helper function
and since it's not identicallty implemented everywhere it cannot
be merged. Instead make the one in SelectionModifier a member function
to move it out of global scope.

BUG=708949
R=yosin@chromium.org

Review-Url: https://codereview.chromium.org/2798143003
Cr-Commit-Position: refs/heads/master@{#462427}
Committed: https://chromium.googlesource.com/chromium/src/+/0736e37b73d70fc56a93eeac32fff4a56c946c2d

[Daniel Bratell, 2017-04-06 07:44:59]

bratell@opera.com changed reviewers:
+ yosin@chromium.org

[Daniel Bratell, 2017-04-06 07:45:00]

Please take a look.

[Daniel Bratell, 2017-04-06 09:14:34]

Description was changed from

==========
Avoid duplicate functions/code in core/editing: DirectionalSelection

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

shouldAlwaysUseDirectionalSelection is a common helper function
and since it's not identicallty implemented everywhere it cannot
be merged. Instead make the one in SelectionModifier a member function
to move it out of global scope.
==========

to

==========
Avoid duplicate functions/code in core/editing: DirectionalSelection

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

shouldAlwaysUseDirectionalSelection is a common helper function
and since it's not identicallty implemented everywhere it cannot
be merged. Instead make the one in SelectionModifier a member function
to move it out of global scope.

BUG=708949
R=yosin@chromium.org
==========

[yosin_UTC9, 2017-04-06 09:57:56]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-04-06 09:57:56]

lgtm

[commit-bot: I haz the power, 2017-04-06 09:58:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 11:33:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491472676234300, "parent_rev":
"8168c8dd3b54ae05890afeeaca934acda86ce7ff", "commit_rev":
"0736e37b73d70fc56a93eeac32fff4a56c946c2d"}

[commit-bot: I haz the power, 2017-04-06 11:33:49]

Description was changed from

==========
Avoid duplicate functions/code in core/editing: DirectionalSelection

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

shouldAlwaysUseDirectionalSelection is a common helper function
and since it's not identicallty implemented everywhere it cannot
be merged. Instead make the one in SelectionModifier a member function
to move it out of global scope.

BUG=708949
R=yosin@chromium.org
==========

to

==========
Avoid duplicate functions/code in core/editing: DirectionalSelection

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

shouldAlwaysUseDirectionalSelection is a common helper function
and since it's not identicallty implemented everywhere it cannot
be merged. Instead make the one in SelectionModifier a member function
to move it out of global scope.

BUG=708949
R=yosin@chromium.org

Review-Url: https://codereview.chromium.org/2798143003
Cr-Commit-Position: refs/heads/master@{#462427}
Committed:
https://chromium.googlesource.com/chromium/src/+/0736e37b73d70fc56a93eeac32ff...
==========

[commit-bot: I haz the power, 2017-04-06 11:33:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0736e37b73d70fc56a93eeac32ff...