third_party/WebKit/Source/core/editing/SelectionModifier.h - Issue 2798143003: Avoid duplicate functions/code in core/editing: DirectionalSelection

Side by Side Diff: third_party/WebKit/Source/core/editing/SelectionModifier.h

Issue 2798143003: Avoid duplicate functions/code in core/editing: DirectionalSelection (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/SelectionModifier.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights	2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights

3 * reserved.	3 * reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
58 VerticalDirection);	58 VerticalDirection);

59	59

60 private:	60 private:

61 // TODO(yosin): We should move \|EPositionType\| to "SelectionModifier.cpp",	61 // TODO(yosin): We should move \|EPositionType\| to "SelectionModifier.cpp",

62 // it is only used for implementing \|modify()\|.	62 // it is only used for implementing \|modify()\|.

63 // TODO(yosin) We should use capitalized name for \|EPositionType\|.	63 // TODO(yosin) We should use capitalized name for \|EPositionType\|.

64 enum EPositionType { START, END, BASE, EXTENT }; // NOLINT	64 enum EPositionType { START, END, BASE, EXTENT }; // NOLINT

65	65

66 LocalFrame* frame() const { return m_frame; }	66 LocalFrame* frame() const { return m_frame; }

67	67

	68 static bool shouldAlwaysUseDirectionalSelection(LocalFrame*);

68 TextDirection directionOfEnclosingBlock() const;	69 TextDirection directionOfEnclosingBlock() const;

69 TextDirection directionOfSelection() const;	70 TextDirection directionOfSelection() const;

70 VisiblePosition positionForPlatform(bool isGetStart) const;	71 VisiblePosition positionForPlatform(bool isGetStart) const;

71 VisiblePosition startForPlatform() const;	72 VisiblePosition startForPlatform() const;

72 VisiblePosition endForPlatform() const;	73 VisiblePosition endForPlatform() const;

73 LayoutUnit lineDirectionPointForBlockDirectionNavigation(EPositionType);	74 LayoutUnit lineDirectionPointForBlockDirectionNavigation(EPositionType);

74 VisiblePosition modifyExtendingRight(TextGranularity);	75 VisiblePosition modifyExtendingRight(TextGranularity);

75 VisiblePosition modifyExtendingForward(TextGranularity);	76 VisiblePosition modifyExtendingForward(TextGranularity);

76 VisiblePosition modifyMovingRight(TextGranularity);	77 VisiblePosition modifyMovingRight(TextGranularity);

77 VisiblePosition modifyMovingForward(TextGranularity);	78 VisiblePosition modifyMovingForward(TextGranularity);

78 VisiblePosition modifyExtendingLeft(TextGranularity);	79 VisiblePosition modifyExtendingLeft(TextGranularity);

79 VisiblePosition modifyExtendingBackward(TextGranularity);	80 VisiblePosition modifyExtendingBackward(TextGranularity);

80 VisiblePosition modifyMovingLeft(TextGranularity);	81 VisiblePosition modifyMovingLeft(TextGranularity);

81 VisiblePosition modifyMovingBackward(TextGranularity);	82 VisiblePosition modifyMovingBackward(TextGranularity);

82 VisiblePosition nextWordPositionForPlatform(const VisiblePosition&);	83 VisiblePosition nextWordPositionForPlatform(const VisiblePosition&);

83	84

84 Member<LocalFrame> m_frame;	85 Member<LocalFrame> m_frame;

85 VisibleSelection m_selection;	86 VisibleSelection m_selection;

86 LayoutUnit m_xPosForVerticalArrowNavigation;	87 LayoutUnit m_xPosForVerticalArrowNavigation;

87	88

88 DISALLOW_COPY_AND_ASSIGN(SelectionModifier);	89 DISALLOW_COPY_AND_ASSIGN(SelectionModifier);

89 };	90 };

90	91

91 LayoutUnit NoXPosForVerticalArrowNavigation();	92 LayoutUnit NoXPosForVerticalArrowNavigation();

92	93

93 } // namespace blink	94 } // namespace blink

94	95

95 #endif // SelectionModifier_h	96 #endif // SelectionModifier_h

OLD	NEW