Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2798113002: [Mac] Remove more dead code from bookmark bar controller (Closed)

Created:
3 years, 8 months ago by lgrey
Modified:
3 years, 8 months ago
Reviewers:
Elly Fong-Jones
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Remove more dead code from bookmark bar controller BUG=648560 Review-Url: https://codereview.chromium.org/2798113002 Cr-Commit-Position: refs/heads/master@{#462465} Committed: https://chromium.googlesource.com/chromium/src/+/744900866f3e97229bf10f54c38eea0316021435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -58 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 5 chunks +0 lines, -28 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
lgrey
PTAL :)
3 years, 8 months ago (2017-04-05 20:43:20 UTC) #6
Elly Fong-Jones
yesssssss lgtm
3 years, 8 months ago (2017-04-06 13:13:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798113002/1
3 years, 8 months ago (2017-04-06 14:30:58 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 14:36:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/744900866f3e97229bf10f54c38e...

Powered by Google App Engine
This is Rietveld 408576698