[Mac] Remove more dead code from bookmark bar controller

chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h"
 
 #include <stddef.h>
 
 #import "base/mac/bundle_locations.h"
 #import "base/mac/foundation_util.h"
@@ skipping 212 matching lines @@
 - (int)indexForDragToPoint:(NSPoint)point;
 
 // Add or remove buttons to/from the bar until it is filled but not overflowed.
 - (void)redistributeButtonsOnBarAsNeeded;
 
 // Determine the nature of the bookmark bar contents based on the number of
 // buttons showing. If too many then show the off-the-side list, if none
 // then show the no items label.
 - (void)reconfigureBookmarkBar;
 
-- (void)clearMenuTagMap;
 - (int)preferredHeight;
 - (void)addButtonsToView;
 - (BOOL)setManagedBookmarksButtonVisibility;
 - (BOOL)setSupervisedBookmarksButtonVisibility;
 - (BOOL)setOtherBookmarksButtonVisibility;
 - (BOOL)setAppsPageShortcutButtonVisibility;
 - (BookmarkButton*)createCustomBookmarkButtonForCell:(NSCell*)cell;
 - (void)createManagedBookmarksButton;
 - (void)createSupervisedBookmarksButton;
 - (void)createOtherBookmarksButton;
@@ skipping 835 matching lines @@
 
 // Actually open the URL.  This is the last chance for a unit test to
 // override.
 - (void)openURL:(GURL)url disposition:(WindowOpenDisposition)disposition {
   OpenURLParams params(
       url, Referrer(), disposition, ui::PAGE_TRANSITION_AUTO_BOOKMARK,
       false);
   browser_->OpenURL(params);
 }
 
-- (void)clearMenuTagMap {
-  seedId_ = 0;
-  menuTagMap_.clear();
-}
-
 - (int)preferredHeight {
   DCHECK(![self isAnimationRunning]);
 
   if (!barIsEnabled_)
     return 0;
 
   switch (currentState_) {
     case BookmarkBar::SHOW:
       return chrome::kMinimumBookmarkBarHeight;
     case BookmarkBar::DETACHED:
       return chrome::kNTPBookmarkBarHeight;
     case BookmarkBar::HIDDEN:
       return 0;
   }
 }
 
 // Return an appropriate width for the given bookmark button cell.
 - (CGFloat)widthForBookmarkButtonCell:(NSCell*)cell {
   return std::min([cell cellSize].width, bookmarks::kDefaultBookmarkWidth);
 }
 
-- (IBAction)openBookmarkMenuItem:(id)sender {
-  int64_t tag = [self nodeIdFromMenuTag:[sender tag]];
-  const BookmarkNode* node =
-      bookmarks::GetBookmarkNodeByID(bookmarkModel_, tag);
-  WindowOpenDisposition disposition =
-      ui::WindowOpenDispositionFromNSEvent([NSApp currentEvent]);
-  [self openURL:node->url() disposition:disposition];
-}
-
 // For the given root node of the bookmark bar, show or hide (as
 // appropriate) the "no items" container (text which says "bookmarks
 // go here").
 - (void)showOrHideNoItemContainerForNode:(const BookmarkNode*)node {
   BOOL hideNoItemWarning = !node->empty();
   [[buttonView_ noItemContainer] setHidden:hideNoItemWarning];
 }
 
 // TODO(jrg): write a "build bar" so there is a nice spot for things
 // like the contextual menu which is invoked when not over a
@@ skipping 669 matching lines @@
 
 // Delete all buttons (bookmarks, chevron, "other bookmarks") from the
 // bookmark bar; reset knowledge of bookmarks.
 - (void)clearBookmarkBar {
   [self stopPulsingBookmarkNode];
   for (BookmarkButton* button in buttons_.get()) {
     [button setDelegate:nil];
     [button removeFromSuperview];
   }
   [buttons_ removeAllObjects];
-  [self clearMenuTagMap];
   displayedButtonCount_ = 0;
 
   // Make sure there are no stale pointers in the pasteboard.  This
   // can be important if a bookmark is deleted (via bookmark sync)
   // while in the middle of a drag.  The "drag completed" code
   // (e.g. [BookmarkBarView performDragOperationForBookmarkButton:]) is
   // careful enough to bail if there is no data found at "drop" time.
   [[NSPasteboard pasteboardWithName:NSDragPboard] clearContents];
 }
 
@@ skipping 82 matching lines @@
 }
 
 // Called when our controlled frame has changed size.
 - (void)frameDidChange {
   if (!bookmarkModel_->loaded())
     return;
   [self updateTheme:[[[self view] window] themeProvider]];
   [self reconfigureBookmarkBar];
 }
 
-// Given a NSMenuItem tag, return the appropriate bookmark node id.
-- (int64_t)nodeIdFromMenuTag:(int32_t)tag {
-  return menuTagMap_[tag];
-}
-
-// Create and return a new tag for the given node id.
-- (int32_t)menuTagFromNodeId:(int64_t)menuid {
-  int tag = seedId_++;
-  menuTagMap_[tag] = menuid;
-  return tag;
-}
-
 // Adapt appearance of buttons to the current theme. Called after
 // theme changes, or when our view is added to the view hierarchy.
 // Oddly, the view pings us instead of us pinging our view.  This is
 // because our trigger is an [NSView viewWillMoveToWindow:], which the
 // controller doesn't normally know about.  Otherwise we don't have
 // access to the theme before we know what window we will be on.
 - (void)updateTheme:(const ui::ThemeProvider*)themeProvider {
   if (!themeProvider)
     return;
   NSColor* color =
@@ skipping 1009 matching lines @@
 - (id<BookmarkButtonControllerProtocol>)controllerForNode:
     (const BookmarkNode*)node {
   // See if it's in the bar, then if it is in the hierarchy of visible
   // folder menus.
   if (bookmarkModel_->bookmark_bar_node() == node)
     return self;
   return [folderController_ controllerForNode:node];
 }
 
 @end