[Bindings] Remove V8HiddenValue

Remove V8HiddenValue class.

This class was used to handle hidden values (private properties) of V8 objects,
and was replaced with V8PrivateProperty.
We no longer need the class itself.


BUG=611864
Review-Url: https://codereview.chromium.org/2798063003
Cr-Commit-Position: refs/heads/master@{#463197}
Committed: https://chromium.googlesource.com/chromium/src/+/91ee8664ce7bc2a8fc792c6144cc8dd4408402b9

[peria, 2017-04-06 08:49:14]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 08:49:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 08:52:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 08:52:46]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[peria, 2017-04-06 09:07:26]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[peria, 2017-04-06 09:07:33]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-06 09:07:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 09:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 09:10:05]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[peria, 2017-04-10 06:19:46]

Patchset #1 (id:20001) has been deleted

[peria, 2017-04-10 06:19:52]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[peria, 2017-04-10 06:19:56]

Patchset #1 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-04-10 06:20:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peria, 2017-04-10 06:46:19]

Description was changed from

==========
Remove V8HiddenValue

BUG=611864
==========

to

==========
Remove V8HiddenValue class.

This class was used to handle hidden values (private properties) of V8 objects,
and was replaced with V8PrivateProperty.
We no longer need the class itself.


BUG=611864
==========

[peria, 2017-04-10 06:50:01]

peria@chromium.org changed reviewers:
+ bashi@chromium.org, haraken@chromium.org, yukishiino@chromium.org

[peria, 2017-04-10 06:50:02]

PTL

[peria, 2017-04-10 06:53:40]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 06:53:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-04-10 06:54:15]

LGTM

You'll need to delete V8HiddenValue.{h,cpp}

[bashi, 2017-04-10 06:58:43]

lgtm

[peria, 2017-04-10 06:59:35]

The CQ bit was unchecked by peria@chromium.org

[peria, 2017-04-10 06:59:35]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2017-04-10 06:59:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 08:47:06]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491807575992230,
"parent_rev": "29cdbc696272f096871b03799f58aa836ef5bb1a", "commit_rev":
"91ee8664ce7bc2a8fc792c6144cc8dd4408402b9"}

[commit-bot: I haz the power, 2017-04-10 08:47:53]

Description was changed from

==========
Remove V8HiddenValue class.

This class was used to handle hidden values (private properties) of V8 objects,
and was replaced with V8PrivateProperty.
We no longer need the class itself.


BUG=611864
==========

to

==========
Remove V8HiddenValue class.

This class was used to handle hidden values (private properties) of V8 objects,
and was replaced with V8PrivateProperty.
We no longer need the class itself.


BUG=611864

Review-Url: https://codereview.chromium.org/2798063003
Cr-Commit-Position: refs/heads/master@{#463197}
Committed:
https://chromium.googlesource.com/chromium/src/+/91ee8664ce7bc2a8fc792c6144cc...
==========

[commit-bot: I haz the power, 2017-04-10 08:47:54]

Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/91ee8664ce7bc2a8fc792c6144cc...

[Yuki, 2017-04-10 09:12:01]

LGTM.

https://codereview.chromium.org/2798063003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.h (right):

https://codereview.chromium.org/2798063003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.h:83:
ListenerProperty(isolate, is_attribute).GetOrEmpty(object);
nit: Better to use GetOrUndefined().

https://codereview.chromium.org/2798063003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.h:91: bool
is_attribute) {
nit:

I think this is a good chance to replace a boolean parameter with an enum type. 
This kind of abuse of booleans is discouraged in Blink's style guide.

https://codereview.chromium.org/2798063003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.h:93: isolate,
is_attribute ? "EventListenerList::attributeListener"
Event listeners are often used, and it deserves to define their own entries in
V8_PRIVATE_PROPERTY_FOR_EACH, I think.