Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1309)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 2798063003: [Bindings] Remove V8HiddenValue (Closed)
Patch Set: remove files Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
index bbfbe6cccb34602e45bb65240a4e8bdea3ddc5ec..20bb8b624584f581a2a22f5bb1cb1c67db4a08c8 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
@@ -41,7 +41,6 @@
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8EventListener.h"
#include "bindings/core/v8/V8HTMLCollection.h"
-#include "bindings/core/v8/V8HiddenValue.h"
#include "bindings/core/v8/V8Node.h"
#include "bindings/core/v8/V8PrivateProperty.h"
#include "core/dom/DOMArrayBuffer.h"
@@ -110,9 +109,8 @@ void V8Window::locationAttributeGetterCustom(
// remote Location objects, we should clean this up to improve
// maintainability. In the long-term, this will be superseded by wrapper
// tracing.
- V8HiddenValue::SetHiddenValue(
- ScriptState::Current(isolate), holder,
- V8AtomicString(isolate, "KeepAlive#Window#location"), wrapper);
+ V8PrivateProperty::GetSymbol(isolate, "KeepAlive#Window#location")
+ .Set(holder, wrapper);
V8SetReturnValue(info, wrapper);
}

Powered by Google App Engine
This is Rietveld 408576698