Issue 2798053003: introduce recipe_exception in result.proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2798053003: introduce recipe_exception in result.proto (Closed)

Created:
3 years, 8 months ago by nodir

Modified:
3 years, 5 months ago

Reviewers:
iannucci, martiniss

CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org

Target Ref:
refs/heads/master

Project:
recipe_engine

Visibility:
Public.

More Reviews

Description

introduce recipe_exception in result.proto Kitchen needs to distinguish arbitrary exceptions from exceptions that happened in the user-supplied recipe. Introduce recipe_exception faiure type in result.proto and populate if an exception was thrown by a recipe. R=iannucci@chromium.org, martiniss@chromium.org BUG=695489

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+153 lines, -26 lines)			Patch
M	recipe_engine/loader.py	View	7 chunks	+41 lines, -5 lines	0 comments	Download
M	recipe_engine/result.proto	View	2 chunks	+13 lines, -3 lines	0 comments	Download
M	recipe_engine/result_pb2.py	View	11 chunks	+62 lines, -12 lines	0 comments	Download
M	recipe_engine/run.py	View	2 chunks	+23 lines, -1 line	0 comments	Download
M	recipe_engine/step_runner.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	recipe_engine/unittests/run_test.py	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	recipes.py	View	1 chunk	+8 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 2802693003 Patch 20001