Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: recipe_engine/result.proto

Issue 2798053003: introduce recipe_exception in result.proto (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « recipe_engine/loader.py ('k') | recipe_engine/result_pb2.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_engine/result.proto
diff --git a/recipe_engine/result.proto b/recipe_engine/result.proto
index 5affb08af1c2305f053309596c1af24fe888b90c..0a319816060a6fb0faac3cf624d9e32387e633e8 100644
--- a/recipe_engine/result.proto
+++ b/recipe_engine/result.proto
@@ -28,9 +28,12 @@ message Failure {
// Step timed out.
Timeout timeout = 2;
- // Step threw an exception.
+ // Recipe engine threw an exception.
Exception exception = 3;
+ // A recipe threw an exception.
+ RecipeException recipe_exception = 6;
+
// Step accessed invalid step data.
StepData step_data = 4;
@@ -39,13 +42,20 @@ message Failure {
}
}
-// An unexpected exception occured during execution. Caused by the builtin
-// Exception class.
+// Recipe engine raised an unexpected exception during execution.
+// Caused by the builtin Exception class.
message Exception {
// Traceback of an exception which occured.
repeated string traceback = 1;
}
+// A recipe raised an unexpected exception during execution.
+// Caused by the builtin Exception class.
+message RecipeException {
+ // Traceback of an exception which occured.
+ repeated string traceback = 1;
+}
+
// A step timed out during its execution. Caused by StepTimeout in
// recipe_api.py
message Timeout {
« no previous file with comments | « recipe_engine/loader.py ('k') | recipe_engine/result_pb2.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698