[regexp] Ensure there are no shape changes on the fast path

[regexp] Ensure there are no shape changes on the fast path

BUG=v8:5437, chromium:708247
Review-Url: https://codereview.chromium.org/2797993002
Cr-Commit-Position: refs/heads/master@{#44428}
Committed: https://chromium.googlesource.com/v8/v8/+/ae459356468ae81955a1298acd255794ac901b4c

[jgruber, 2017-04-05 10:45:59]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 10:46:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-05 10:50:47]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[jgruber, 2017-04-05 10:50:48]

PTAL: This is a proposed fix for the OOB access through exec by taking the slow
path when lastIndex is not a non-negative smi and omitting ToLength(lastIndex)
on the fast path.

TODO: Tests, and cleaning this up to make backmerging easier.

[commit-bot: I haz the power, 2017-04-05 11:04:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 11:04:24]

Dry run: Try jobs failed on following builders:
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/23830)
  v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_linux_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng_...)

[Yang, 2017-04-05 12:07:36]

On 2017/04/05 10:50:48, jgruber wrote:
> PTAL: This is a proposed fix for the OOB access through exec by taking the
slow
> path when lastIndex is not a non-negative smi and omitting ToLength(lastIndex)
> on the fast path.
> 
> TODO: Tests, and cleaning this up to make backmerging easier.

lgtm.

[jgruber, 2017-04-06 06:49:52]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 06:50:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-06 07:01:22]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 07:01:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-06 07:02:12]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 07:02:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-06 07:05:57]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 07:06:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-06 07:17:08]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 07:17:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 07:54:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 07:54:04]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-04-06 08:11:39]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-04-06 08:11:39]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2797993002/#ps90001
(title: "Add test")

[commit-bot: I haz the power, 2017-04-06 08:11:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 08:12:56]

CQ is committing da patch.

Bot data: {"patchset_id": 90001, "attempt_start_ts": 1491466299469160,
"parent_rev": "108e96a4fccc7638305adc257d4f335f1b1fe66b", "commit_rev":
"ae459356468ae81955a1298acd255794ac901b4c"}

[commit-bot: I haz the power, 2017-04-06 08:13:02]

Description was changed from

==========
[regexp] Ensure there are no shape changes on the fast path

BUG=v8:5437,chromium:708247
==========

to

==========
[regexp] Ensure there are no shape changes on the fast path

BUG=v8:5437,chromium:708247

Review-Url: https://codereview.chromium.org/2797993002
Cr-Commit-Position: refs/heads/master@{#44428}
Committed:
https://chromium.googlesource.com/v8/v8/+/ae459356468ae81955a1298acd255794ac9...
==========

[commit-bot: I haz the power, 2017-04-06 08:13:03]

Committed patchset #6 (id:90001) as
https://chromium.googlesource.com/v8/v8/+/ae459356468ae81955a1298acd255794ac9...