Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: src/builtins/builtins-regexp-gen.h

Issue 2797993002: [regexp] Ensure there are no shape changes on the fast path (Closed)
Patch Set: Add test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/builtins/builtins-regexp-gen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-regexp-gen.h
diff --git a/src/builtins/builtins-regexp-gen.h b/src/builtins/builtins-regexp-gen.h
index 440cc6b7f5b2779bb763ad79f0b3ec3517e090ae..7c818e750a25dc3422017b6b17b278a5ba1d6e09 100644
--- a/src/builtins/builtins-regexp-gen.h
+++ b/src/builtins/builtins-regexp-gen.h
@@ -15,8 +15,8 @@ class RegExpBuiltinsAssembler : public CodeStubAssembler {
explicit RegExpBuiltinsAssembler(compiler::CodeAssemblerState* state)
: CodeStubAssembler(state) {}
- void BranchIfFastRegExp(Node* const context, Node* const map,
- Label* const if_isunmodified,
+ void BranchIfFastRegExp(Node* const context, Node* const object,
+ Node* const map, Label* const if_isunmodified,
Label* const if_ismodified);
protected:
@@ -58,9 +58,13 @@ class RegExpBuiltinsAssembler : public CodeStubAssembler {
char const* method_name);
// Analogous to BranchIfFastRegExp, for use in asserts.
- Node* IsFastRegExpMap(Node* const context, Node* const map);
+ Node* IsFastRegExp(Node* const context, Node* const object, Node* const map);
+
+ // Performs fast path checks on the given object itself, but omits prototype
+ // checks.
+ Node* IsFastRegExpNoPrototype(Node* const context, Node* const object,
+ Node* const map);
- Node* IsInitialRegExpMap(Node* context, Node* map);
void BranchIfFastRegExpResult(Node* context, Node* map,
Label* if_isunmodified, Label* if_ismodified);
« no previous file with comments | « no previous file | src/builtins/builtins-regexp-gen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698