Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 2797953002: Revert increased limit for m_selectorIndex. (Closed)

Created:
3 years, 8 months ago by rune
Modified:
3 years, 8 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert increased limit for m_selectorIndex. If 2^13 simple selectors in a style rule was not enough, 2^14 will be exceeded at some point. Leave the available bit for later use and avoid regressions for m_selectorIndex when we need that bit. R=esprehn@chromium.org BUG=704562 Review-Url: https://codereview.chromium.org/2797953002 Cr-Commit-Position: refs/heads/master@{#462015} Committed: https://chromium.googlesource.com/chromium/src/+/6a550e547934bfce597bab1d52bf89a3ae18d1df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M third_party/WebKit/Source/core/css/RuleSet.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/RuleSetTest.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
rune
Reverting bitfield change, but keeping added comments and unit test. ptal
3 years, 8 months ago (2017-04-05 07:34:57 UTC) #1
esprehn
lgtm
3 years, 8 months ago (2017-04-05 08:27:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797953002/1
3 years, 8 months ago (2017-04-05 09:12:56 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 09:17:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6a550e547934bfce597bab1d52bf...

Powered by Google App Engine
This is Rietveld 408576698