Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: third_party/WebKit/Source/core/css/RuleSetTest.cpp

Issue 2797953002: Revert increased limit for m_selectorIndex. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/RuleSet.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/RuleSetTest.cpp
diff --git a/third_party/WebKit/Source/core/css/RuleSetTest.cpp b/third_party/WebKit/Source/core/css/RuleSetTest.cpp
index a1fdff3f848833b3c2f6f8e1285d1604afe80191..46aaf5e5847411e566b6b944887779aac3aadd0d 100644
--- a/third_party/WebKit/Source/core/css/RuleSetTest.cpp
+++ b/third_party/WebKit/Source/core/css/RuleSetTest.cpp
@@ -199,7 +199,10 @@ TEST(RuleSetTest, findBestRuleSetAndAdd_HostContextAndClass) {
TEST(RuleSetTest, SelectorIndexLimit) {
StringBuilder builder;
- for (unsigned i = 0; i < 16383; i++)
+ // We use 13 bits to storing the selector start index in RuleData. This is a
+ // test to check that we don't regress. We WONTFIX issues asking for more
+ // since 2^13 simple selectors in a style rule is already excessive.
+ for (unsigned i = 0; i < 8191; i++)
builder.append("div,");
builder.append("b,span {}");
« no previous file with comments | « third_party/WebKit/Source/core/css/RuleSet.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698