Issue 2797923008: Fix updating packages map on reload and add a regression test

Issue 2797923008: Fix updating packages map on reload and add a regression test (Closed)

Created:
3 years, 8 months ago by Cutch

Modified:
3 years, 8 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix updating packages map on reload and add a regression test - [x] Update the isolate's .packages path when requested. - [x] Always refresh package map when loader is initialized. - [x] Add regression test. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/7a2d67f3baf80eea0ceddf70aea67e5298397117

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -9 lines)			Patch
M	runtime/bin/isolate_data.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/bin/loader.cc	View		1 chunk	+9 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/loader.dart	View	1	3 chunks	+9 lines, -5 lines	0 comments	Download
M	runtime/observatory/lib/src/service/object.dart	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
A	runtime/observatory/tests/service/complex_reload/v2/.gitignore	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	runtime/observatory/tests/service/complex_reload/v2/foobar_lib/foo.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/observatory/tests/service/complex_reload/v2/main.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
A	runtime/observatory/tests/service/complex_reload/v2/packages	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/observatory/tests/service/complex_reload_test.dart	View	1	2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 6 (3 generated)

Cutch

3 years, 8 months ago (2017-04-10 15:59:17 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7a2d67f3baf80eea0ceddf70aea67e5298397117 (presubmit successful).