Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 2797923008: Fix updating packages map on reload and add a regression test (Closed)
Patch Set: Fix loader logic Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/loader.dart ('k') | runtime/observatory/tests/service/complex_reload/v2/.gitignore » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 3f99b907bb3361b5a81a3f98ef6eca9ce56d3419..0e941b9f633e0119a89157a42addcdec0152ac86 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -1356,11 +1356,15 @@ class Isolate extends ServiceObjectOwner implements M.Isolate {
return invokeRpc('getSourceReport', params);
}
- Future<ServiceMap> reloadSources({String rootLibUri, bool pause}) {
+ Future<ServiceMap> reloadSources(
+ {String rootLibUri, String packagesUri, bool pause}) {
Map<String, dynamic> params = <String, dynamic>{};
if (rootLibUri != null) {
params['rootLibUri'] = rootLibUri;
}
+ if (packagesUri != null) {
+ params['packagesUri'] = packagesUri;
+ }
if (pause != null) {
params['pause'] = pause;
}
« no previous file with comments | « runtime/bin/vmservice/loader.dart ('k') | runtime/observatory/tests/service/complex_reload/v2/.gitignore » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698