Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: runtime/observatory/tests/service/complex_reload_test.dart

Issue 2797923008: Fix updating packages map on reload and add a regression test (Closed)
Patch Set: Fix loader logic Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/complex_reload/v2/packages ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/complex_reload_test.dart
diff --git a/runtime/observatory/tests/service/complex_reload_test.dart b/runtime/observatory/tests/service/complex_reload_test.dart
index 4c288fb4eeeb6da9fe6b2c61eca169439228c435..7602df02d7911e919e14556e2b589691b0f3233d 100644
--- a/runtime/observatory/tests/service/complex_reload_test.dart
+++ b/runtime/observatory/tests/service/complex_reload_test.dart
@@ -20,6 +20,7 @@ Uri baseUri = Platform.script.replace(path: baseDirectory);
Uri spawnUri = baseUri.resolveUri(Uri.parse('complex_reload/v1/main.dart'));
Uri v2Uri = baseUri.resolveUri(Uri.parse('complex_reload/v2/main.dart'));
Uri v3Uri = baseUri.resolveUri(Uri.parse('complex_reload/v3/main.dart'));
+Uri v2PackagesUri = baseUri.resolveUri(Uri.parse('complex_reload/v2/packages'));
testMain() async {
print(baseUri);
@@ -64,13 +65,14 @@ var tests = [
// Reload to v2.
var response = await slaveIsolate.reloadSources(
rootLibUri: v2Uri.toString(),
+ packagesUri: v2PackagesUri.toString(),
);
print(response);
expect(response['success'], isTrue);
// Invoke test in v2.
String v2 = await invokeTest(slaveIsolate);
- expect(v2, 'banana');
+ expect(v2, 'fooLib');
// Reload to v3.
response = await slaveIsolate.reloadSources(
« no previous file with comments | « runtime/observatory/tests/service/complex_reload/v2/packages ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698