Issue 2797823002: Fix tab deselect notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2797823002: Fix tab deselect notifications. (Closed)

Created:
3 years, 8 months ago by justincohen

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

Fix tab deselect notifications. Fix the post notification for tab deselection to send from the proper object and include the userInfo. BUG=705826 TEST=no visible changes. Review-Url: https://codereview.chromium.org/2788233002 Cr-Commit-Position: refs/heads/master@{#461426} (cherry picked from commit 71e3604b522136b8fe4226941b67b72f56c7d921) Review-Url: https://codereview.chromium.org/2797823002 . Cr-Commit-Position: refs/branch-heads/3029@{#576} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/1a0218a9df0639f60d99fad06554acb2ff8176d4

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ios/chrome/browser/tabs/tab_model_selected_tab_observer.mm	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

justincohen

3 years, 8 months ago (2017-04-04 19:29:46 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1a0218a9df0639f60d99fad06554acb2ff8176d4.