Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2788233002: Fix tab deselect notifications. (Closed)

Created:
3 years, 8 months ago by pink (ping after 24hrs)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix tab deselect notifications. Fix the post notification for tab deselection to send from the proper object and include the userInfo. BUG=705826 TEST=no visible changes. Review-Url: https://codereview.chromium.org/2788233002 Cr-Commit-Position: refs/heads/master@{#461426} Committed: https://chromium.googlesource.com/chromium/src/+/71e3604b522136b8fe4226941b67b72f56c7d921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ios/chrome/browser/tabs/tab_model_selected_tab_observer.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
pink (ping after 24hrs)
3 years, 8 months ago (2017-03-31 20:16:05 UTC) #2
rohitrao (ping after 24h)
lgtm lgtm +sdefresne FYI
3 years, 8 months ago (2017-04-03 14:10:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788233002/1
3 years, 8 months ago (2017-04-03 14:14:19 UTC) #5
sdefresne
lgtm (oops)
3 years, 8 months ago (2017-04-03 14:19:26 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 14:28:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/71e3604b522136b8fe4226941b67...

Powered by Google App Engine
This is Rietveld 408576698