Save the logcat file in isolated directory.

Save the logcat file in isolated directory.

Previously we store the logcat into a temporary directory, which will be
deleted shortly. That means logcat will not be viewable in the isolated
directory.

In this cl, we are storing the logcat in the isolated directory, for
later easier view. This is a temporary fix before result details is
enabled.

BUG=707387
Review-Url: https://codereview.chromium.org/2797773003
Cr-Commit-Position: refs/heads/master@{#461898}
Committed: https://chromium.googlesource.com/chromium/src/+/9ae14459caaa7f3b049b3d44be2c209890773213

[BigBossZhiling, 2017-04-04 20:21:30]

Description was changed from

==========
Save the logcat file in isolated directory.

Previously we store the logcat into a temporary directory, which will be
deleted shortly. That means logcat will not be viewable in the isolated
directory.

In this cl, we are storing the logcat in the isolated directory, for
later easier view. This is a temporary fix before result details is
enabled.

BUG=707387
==========

to

==========
Save the logcat file in isolated directory.

Previously we store the logcat into a temporary directory, which will be
deleted shortly. That means logcat will not be viewable in the isolated
directory.

In this cl, we are storing the logcat in the isolated directory, for
later easier view. This is a temporary fix before result details is
enabled.

BUG=707387
==========

[BigBossZhiling, 2017-04-04 20:21:31]

hzl@google.com changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2017-04-04 20:53:22]

lgtm as a temporary solution.

[BigBossZhiling, 2017-04-04 20:53:51]

The CQ bit was checked by hzl@google.com

[commit-bot: I haz the power, 2017-04-04 20:54:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 21:10:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 21:10:46]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[BigBossZhiling, 2017-04-04 21:28:46]

hzl@google.com changed reviewers:
+ dpranke@chromium.org

[mikecase (-- gone --), 2017-04-04 23:14:15]

mikecase@chromium.org changed reviewers:
+ mikecase@chromium.org

[mikecase (-- gone --), 2017-04-04 23:14:16]

We already upload the logcat to logdog. Is this really necessary? We could
easily add the logdog link into the results.json (we might already do this?) and
can surface it as a buildbot step link.

[jbudorick, 2017-04-04 23:19:11]

On 2017/04/04 23:14:16, mikecase wrote:
> We already upload the logcat to logdog. Is this really necessary? We could
> easily add the logdog link into the results.json (we might already do this?)
and
> can surface it as a buildbot step link.

For maintaining user expectations until we have a better story, yes. That links
part is going to be part of landing result_details once
https://chromium-review.googlesource.com/c/465068/ lands. People are firing CLs
in the meantime, though, and pinging me as to where to find the logcats :/

[Dirk Pranke, 2017-04-04 23:26:36]

lgtm

[BigBossZhiling, 2017-04-04 23:26:55]

The CQ bit was checked by hzl@google.com

[commit-bot: I haz the power, 2017-04-04 23:27:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 23:38:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491348415644270, "parent_rev":
"fc74eba202a1ca36ae1465dda45b3ca854ea3e98", "commit_rev":
"9ae14459caaa7f3b049b3d44be2c209890773213"}

[commit-bot: I haz the power, 2017-04-04 23:39:04]

Description was changed from

==========
Save the logcat file in isolated directory.

Previously we store the logcat into a temporary directory, which will be
deleted shortly. That means logcat will not be viewable in the isolated
directory.

In this cl, we are storing the logcat in the isolated directory, for
later easier view. This is a temporary fix before result details is
enabled.

BUG=707387
==========

to

==========
Save the logcat file in isolated directory.

Previously we store the logcat into a temporary directory, which will be
deleted shortly. That means logcat will not be viewable in the isolated
directory.

In this cl, we are storing the logcat in the isolated directory, for
later easier view. This is a temporary fix before result details is
enabled.

BUG=707387

Review-Url: https://codereview.chromium.org/2797773003
Cr-Commit-Position: refs/heads/master@{#461898}
Committed:
https://chromium.googlesource.com/chromium/src/+/9ae14459caaa7f3b049b3d44be2c...
==========

[commit-bot: I haz the power, 2017-04-04 23:39:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9ae14459caaa7f3b049b3d44be2c...