Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1750)

Unified Diff: build/android/test_wrapper/logdog_wrapper.py

Issue 2797773003: Save the logcat file in isolated directory. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/mb/mb.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/test_wrapper/logdog_wrapper.py
diff --git a/build/android/test_wrapper/logdog_wrapper.py b/build/android/test_wrapper/logdog_wrapper.py
index e3904f51bdbb51563a0e6bef4c73278368be0cdc..5213cb367d38708842f8f719dc43cb09b3af13d7 100755
--- a/build/android/test_wrapper/logdog_wrapper.py
+++ b/build/android/test_wrapper/logdog_wrapper.py
@@ -36,6 +36,8 @@ def CommandParser():
help='The logdog bin cmd.')
parser.add_argument('--target-devices-file', required=False,
help='The target devices file.')
+ parser.add_argument('--logcat-output-file',
+ help='The logcat output file.')
return parser
def CreateStopTestsMethod(proc):
@@ -52,7 +54,9 @@ def main():
with tempfile_ext.NamedTemporaryDirectory() as logcat_output_dir:
test_cmd = [
os.path.join('bin', 'run_%s' % args.target),
- '--logcat-output-file', os.path.join(logcat_output_dir, 'logcats'),
+ '--logcat-output-file',
+ (args.logcat_output_file if args.logcat_output_file
+ else os.path.join(logcat_output_dir, 'logcats')),
'--upload-logcats-file',
'--target-devices-file', args.target_devices_file,
'-v'] + extra_cmd_args
« no previous file with comments | « no previous file | tools/mb/mb.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698