Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Issue 2797763003: DevTools: Show the full chain of initiators on the flame chart. (Closed)

Created:
3 years, 8 months ago by alph
Modified:
3 years, 8 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Show the full chain of initiators on the flame chart. BUG=646928 Review-Url: https://codereview.chromium.org/2797763003 Cr-Commit-Position: refs/heads/master@{#461808} Committed: https://chromium.googlesource.com/chromium/src/+/bcb48dd23776da9be2de3a01bc471feb0aef5cfe

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js View 1 1 chunk +16 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
alph
3 years, 8 months ago (2017-04-04 17:59:05 UTC) #2
caseq
lgtm https://codereview.chromium.org/2797763003/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js (right): https://codereview.chromium.org/2797763003/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js#newcode882 third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:882: if (!this._isVisible(event)) do you still need this check? ...
3 years, 8 months ago (2017-04-04 18:07:28 UTC) #3
alph
all done
3 years, 8 months ago (2017-04-04 18:14:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797763003/20001
3 years, 8 months ago (2017-04-04 18:15:43 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 20:07:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bcb48dd23776da9be2de3a01bc47...

Powered by Google App Engine
This is Rietveld 408576698