Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js

Issue 2797763003: DevTools: Show the full chain of initiators on the flame chart. (Closed)
Patch Set: Addressing comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
index 65e833d9ac1510079c0c73e6984c7d904010429d..be44c2e2db2b4f992df436ae59c9acfb0ad9950e 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
@@ -875,23 +875,24 @@ Timeline.TimelineFlameChartDataProvider = class {
td.flowStartLevels = [];
td.flowEndTimes = [];
td.flowEndLevels = [];
- // Find the closest ancestor with an initiator.
- var initiator;
- for (; event; event = this._eventParent(event)) {
- if (!this._isVisible(event))
- continue;
- initiator = TimelineModel.TimelineData.forEvent(event).initiator();
- if (initiator)
+ while (event) {
+ // Find the closest ancestor with an initiator.
+ var initiator;
+ for (; event; event = this._eventParent(event)) {
+ initiator = TimelineModel.TimelineData.forEvent(event).initiator();
+ if (initiator)
+ break;
+ }
+ if (!initiator)
break;
+ var eventIndex = event[Timeline.TimelineFlameChartDataProvider._indexSymbol];
+ var initiatorIndex = initiator[Timeline.TimelineFlameChartDataProvider._indexSymbol];
+ td.flowStartTimes.push(initiator.endTime || initiator.startTime);
+ td.flowStartLevels.push(td.entryLevels[initiatorIndex]);
+ td.flowEndTimes.push(event.startTime);
+ td.flowEndLevels.push(td.entryLevels[eventIndex]);
+ event = initiator;
}
- if (!initiator || !this._isVisible(initiator))
- return true;
- var eventIndex = event[Timeline.TimelineFlameChartDataProvider._indexSymbol];
- var initiatorIndex = initiator[Timeline.TimelineFlameChartDataProvider._indexSymbol];
- td.flowStartTimes.push(initiator.endTime || initiator.startTime);
- td.flowStartLevels.push(td.entryLevels[initiatorIndex]);
- td.flowEndTimes.push(event.startTime);
- td.flowEndLevels.push(td.entryLevels[eventIndex]);
return true;
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698