Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1549)

Issue 2797513003: Revert of NativeStackSampler implementation for Mac. (Closed)

Created:
3 years, 8 months ago by Avi (use Gerrit)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, mac-reviews_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of NativeStackSampler implementation for Mac. (patchset #21 id:400001 of https://codereview.chromium.org/2702463003/ ) Reason for revert: WebGL crashes. http://crbug.com/707474 Original issue's description: > NativeStackSampler implementation for Mac. > > Stack sampling on Mac implemented for StackSamplingProfiler to provide > Chrome stack trace data from Mac users to UMA. > > BUG=531673 > > Review-Url: https://codereview.chromium.org/2702463003 > Cr-Commit-Position: refs/heads/master@{#461145} > Committed: https://chromium.googlesource.com/chromium/src/+/965a47b7737c6f15238447d8d8fb7105183acc8a TBR=wittman@chromium.org,mark@chromium.org,rsesek@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=531673 Review-Url: https://codereview.chromium.org/2797513003 Cr-Commit-Position: refs/heads/master@{#461762} Committed: https://chromium.googlesource.com/chromium/src/+/806487f6ebc2cbf35c061e5154db29ac44a55738

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -518 lines) Patch
M base/BUILD.gn View 5 chunks +2 lines, -12 lines 0 comments Download
D base/profiler/native_stack_sampler_mac.cc View 1 chunk +0 lines, -471 lines 0 comments Download
M base/profiler/native_stack_sampler_win.cc View 2 chunks +11 lines, -6 lines 0 comments Download
M base/profiler/stack_sampling_profiler_unittest.cc View 6 chunks +5 lines, -10 lines 0 comments Download
M chrome/common/stack_sampling_configuration.cc View 2 chunks +8 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Avi (use Gerrit)
Created Revert of NativeStackSampler implementation for Mac.
3 years, 8 months ago (2017-04-04 16:06:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797513003/1
3 years, 8 months ago (2017-04-04 16:06:28 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 17:21:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/806487f6ebc2cbf35c061e5154db...

Powered by Google App Engine
This is Rietveld 408576698