Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Unified Diff: base/BUILD.gn

Issue 2797513003: Revert of NativeStackSampler implementation for Mac. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/profiler/native_stack_sampler_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index f8c4dba14d90c63364611c9e49c27a6cb2d57b89..3125e8d99aec1e232a1bae54d30da03e14a38f4f 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -722,7 +722,6 @@
"process/process_win.cc",
"profiler/native_stack_sampler.cc",
"profiler/native_stack_sampler.h",
- "profiler/native_stack_sampler_mac.cc",
"profiler/native_stack_sampler_posix.cc",
"profiler/native_stack_sampler_win.cc",
"profiler/scoped_profile.cc",
@@ -1467,10 +1466,6 @@
"strings/sys_string_conversions_posix.cc",
"threading/platform_thread_internal_posix.cc",
]
-
- if (is_mac) {
- sources -= [ "profiler/native_stack_sampler_posix.cc" ]
- }
} else {
# Non-Mac/ios.
sources -= [
@@ -1843,9 +1838,7 @@
"//base/win:base_win_features",
]
}
-}
-
-if (is_win || is_mac) {
+
if (current_cpu == "x64") {
# Must be a shared library so that it can be unloaded during testing.
shared_library("base_profiler_test_support_library") {
@@ -2307,9 +2300,6 @@
"CoreFoundation.framework",
"Foundation.framework",
]
- if (current_cpu == "x64") {
- data_deps += [ ":base_profiler_test_support_library" ]
- }
}
if (is_linux) {
@@ -2348,7 +2338,7 @@
deps += [ "//base:scoped_handle_test_dll" ]
if (current_cpu == "x64") {
sources += [ "profiler/win32_stack_frame_unwinder_unittest.cc" ]
- data_deps += [ ":base_profiler_test_support_library" ]
+ deps += [ ":base_profiler_test_support_library" ]
}
}
« no previous file with comments | « no previous file | base/profiler/native_stack_sampler_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698