Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2797453004: [ES6 modules] Introduce ScriptModuleTest and test ::compile() (Closed)

Created:
3 years, 8 months ago by kouhei (in TOK)
Modified:
3 years, 8 months ago
Reviewers:
haraken, adamk, yhirano
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ES6 modules] Introduce ScriptModuleTest and test ::compile() This CL introduce ScriptModuleTest, a unit test for ScriptModule. ScriptModule::compile() method is now unit-tested briefly. BUG=594639 Review-Url: https://codereview.chromium.org/2797453004 Cr-Commit-Position: refs/heads/master@{#461636} Committed: https://chromium.googlesource.com/chromium/src/+/e50d7a2ae677c7a766c0a74385d367d757a4699e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/bindings.gni View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp View 1 chunk +31 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
kouhei (in TOK)
3 years, 8 months ago (2017-04-04 00:45:12 UTC) #2
haraken
LGTM
3 years, 8 months ago (2017-04-04 02:04:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797453004/1
3 years, 8 months ago (2017-04-04 03:49:21 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 05:28:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e50d7a2ae677c7a766c0a74385d3...

Powered by Google App Engine
This is Rietveld 408576698