[ES6 modules] Introduce ScriptModule::moduleRequests to access record.[[RequestedModules]]

[ES6 modules] Introduce ScriptModule::moduleRequests to access record.[[RequestedModules]]

This CL introduces ScriptModule::moduleRequests, a V8 binding for v8::Module::GetModuleRequest.

BUG=594639
Review-Url: https://codereview.chromium.org/2788573002
Cr-Commit-Position: refs/heads/master@{#461693}
Committed: https://chromium.googlesource.com/chromium/src/+/5f7862ecfcdcdf42328842d94b7eaf039bd2e839

[kouhei (in TOK), 2017-03-30 06:14:38]

kouhei@chromium.org changed reviewers:
+ adamk@chromium.org, haraken@chromium.org, hiroshige@chromium.org,
neis@chromium.org, yhirano@chromium.org

[neis, 2017-03-30 06:41:29]

lgtm

[haraken, 2017-03-30 13:17:12]

Can we add a test?

[kouhei (in TOK), 2017-04-04 04:27:49]

On 2017/03/30 13:17:12, haraken wrote:
> Can we add a test?

Done.

[kouhei (in TOK), 2017-04-04 04:27:57]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 04:28:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-04-04 04:32:10]

LGTM

https://codereview.chromium.org/2788573002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp (right):

https://codereview.chromium.org/2788573002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp:69:
ret.push_back(name);

ret.push_back(toCoreString(v8Name));

[kouhei (in TOK), 2017-04-04 05:21:49]

On 2017/04/04 04:32:10, haraken wrote:
> LGTM
> 
>
https://codereview.chromium.org/2788573002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp (right):
> 
>
https://codereview.chromium.org/2788573002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp:69:
> ret.push_back(name);
> 
> ret.push_back(toCoreString(v8Name));

Done.

[kouhei (in TOK), 2017-04-04 05:21:52]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2017-04-04 05:21:53]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org,
haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2788573002/#ps60001
(title: "haraken")

[commit-bot: I haz the power, 2017-04-04 05:22:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 05:22:07]

This CL has an open dependency (Issue 2797453004 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[kouhei (in TOK), 2017-04-04 05:23:03]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 05:23:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 05:29:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 05:29:11]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kouhei (in TOK), 2017-04-04 11:59:31]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2017-04-04 11:59:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 12:02:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 12:02:51]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[kouhei (in TOK), 2017-04-04 12:05:35]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2017-04-04 12:05:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2788573002/#ps80001
(title: "rebased")

[commit-bot: I haz the power, 2017-04-04 12:05:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 13:27:26]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491307535787260,
"parent_rev": "f3800a0ecbf562fab539af5a06c69244ad09e990", "commit_rev":
"5f7862ecfcdcdf42328842d94b7eaf039bd2e839"}

[commit-bot: I haz the power, 2017-04-04 13:28:18]

Description was changed from

==========
[ES6 modules] Introduce ScriptModule::moduleRequests to access
record.[[RequestedModules]]

This CL introduces ScriptModule::moduleRequests, a V8 binding for
v8::Module::GetModuleRequest.

BUG=594639
==========

to

==========
[ES6 modules] Introduce ScriptModule::moduleRequests to access
record.[[RequestedModules]]

This CL introduces ScriptModule::moduleRequests, a V8 binding for
v8::Module::GetModuleRequest.

BUG=594639

Review-Url: https://codereview.chromium.org/2788573002
Cr-Commit-Position: refs/heads/master@{#461693}
Committed:
https://chromium.googlesource.com/chromium/src/+/5f7862ecfcdcdf42328842d94b7e...
==========

[commit-bot: I haz the power, 2017-04-04 13:28:19]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/5f7862ecfcdcdf42328842d94b7e...