Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2112)

Unified Diff: chrome/installer/setup/setup_install_details.cc

Issue 2797433002: Include Google Update integration details in crash keys and about:version. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/setup_install_details.cc
diff --git a/chrome/installer/setup/setup_install_details.cc b/chrome/installer/setup/setup_install_details.cc
index e09b1b7fa7eab101e7f62de95ca3db4b1772d00f..ab63ddca3990f43e5f4da8245bfff4931b638a79 100644
--- a/chrome/installer/setup/setup_install_details.cc
+++ b/chrome/installer/setup/setup_install_details.cc
@@ -92,8 +92,16 @@ std::unique_ptr<install_static::PrimaryInstallDetails> MakeInstallDetails(
// ClientState registry key or the mode's ClientState registry key. Which one
// is used depends on whether or not this Chrome is updating from a legacy
// multi-install Chrome.
+
+ // Cache the ap and cohort name values found in the registry for use in crash
+ // keys.
+ base::string16 update_ap;
+ base::string16 update_cohort_name;
details->set_channel(install_static::DetermineChannel(
- *mode, system_level, IsUpdatingFromMulti(*mode, system_level)));
+ *mode, system_level, IsUpdatingFromMulti(*mode, system_level), &update_ap,
+ &update_cohort_name));
+ details->set_update_ap(update_ap);
+ details->set_update_cohort_name(update_cohort_name);
return details;
}

Powered by Google App Engine
This is Rietveld 408576698