Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: chrome/installer/setup/setup_install_details.cc

Issue 2797433002: Include Google Update integration details in crash keys and about:version. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/installer/setup/setup_install_details.h" 5 #include "chrome/installer/setup/setup_install_details.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "base/win/registry.h" 10 #include "base/win/registry.h"
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 details->set_system_level(system_level); 85 details->set_system_level(system_level);
86 86
87 // The channel is determined based on the brand and the mode's 87 // The channel is determined based on the brand and the mode's
88 // ChannelStrategy. For brands that do not support Google Update, the channel 88 // ChannelStrategy. For brands that do not support Google Update, the channel
89 // is an empty string. For modes using the FIXED strategy, the channel is the 89 // is an empty string. For modes using the FIXED strategy, the channel is the
90 // default_channel_name in the mode. For modes using the ADDITIONAL_PARAMETERS 90 // default_channel_name in the mode. For modes using the ADDITIONAL_PARAMETERS
91 // strategy, the channel is parsed from the "ap" value in either the binaries' 91 // strategy, the channel is parsed from the "ap" value in either the binaries'
92 // ClientState registry key or the mode's ClientState registry key. Which one 92 // ClientState registry key or the mode's ClientState registry key. Which one
93 // is used depends on whether or not this Chrome is updating from a legacy 93 // is used depends on whether or not this Chrome is updating from a legacy
94 // multi-install Chrome. 94 // multi-install Chrome.
95
96 // Cache the ap and cohort name values found in the registry for use in crash
97 // keys.
98 base::string16 update_ap;
99 base::string16 update_cohort_name;
95 details->set_channel(install_static::DetermineChannel( 100 details->set_channel(install_static::DetermineChannel(
96 *mode, system_level, IsUpdatingFromMulti(*mode, system_level))); 101 *mode, system_level, IsUpdatingFromMulti(*mode, system_level), &update_ap,
102 &update_cohort_name));
103 details->set_update_ap(update_ap);
104 details->set_update_cohort_name(update_cohort_name);
97 105
98 return details; 106 return details;
99 } 107 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698