Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2725)

Unified Diff: chrome/installer/setup/installer_crash_reporting.cc

Issue 2797433002: Include Google Update integration details in crash keys and about:version. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/installer_crash_reporting.cc
diff --git a/chrome/installer/setup/installer_crash_reporting.cc b/chrome/installer/setup/installer_crash_reporting.cc
index 137913a1ab84f2534ed5114ac389284c43868339..b8ecb8bc766a0ace3689c0c8a5f4b2d746a0fd8c 100644
--- a/chrome/installer/setup/installer_crash_reporting.cc
+++ b/chrome/installer/setup/installer_crash_reporting.cc
@@ -31,6 +31,8 @@ namespace {
// Crash Keys
+const char kApValue[] = "ap";
+const char kCohortName[] = "cohort-name";
const char kCurrentVersion[] = "current-version";
const char kIsSystemLevel[] = "system-level";
const char kOperation[] = "operation";
@@ -129,6 +131,14 @@ void SetInitialCrashKeys(const InstallerState& state) {
const base::string16 state_key = state.state_key();
if (!state_key.empty())
SetCrashKeyValue(kStateKey, base::UTF16ToUTF8(state_key));
+
+ // Set crash keys containing the registry values used to determine Chrome's
+ // update channel at process startup; see https://crbug.com/579504.
+ const auto& details = install_static::InstallDetails::Get();
+ base::debug::SetCrashKeyValue(kApValue,
+ base::UTF16ToUTF8(details.update_ap()));
+ base::debug::SetCrashKeyValue(
+ kCohortName, base::UTF16ToUTF8(details.update_cohort_name()));
}
void SetCrashKeysFromCommandLine(const base::CommandLine& command_line) {

Powered by Google App Engine
This is Rietveld 408576698