Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2797313003: Remove DCHECK in column balancer that failed because of flexbox bugs. (Closed)

Created:
3 years, 8 months ago by mstensho (USE GERRIT)
Modified:
3 years, 8 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DCHECK in column balancer that failed because of flexbox bugs. This DCHECK was useful (detects broken layout, but nothing more dangerous than that). However, as long as we don't paginate flex items at their final block position (see bug 606350), we cannot assert like this, because it's going to fail under certain circumstances. BUG=685047 Review-Url: https://codereview.chromium.org/2797313003 Cr-Commit-Position: refs/heads/master@{#462447} Committed: https://chromium.googlesource.com/chromium/src/+/0ab573d311cd7a4a72b86ee8d47a7b70b358432b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/nested-with-wrapped-flexbox-crash.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ColumnBalancer.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mstensho (USE GERRIT)
3 years, 8 months ago (2017-04-06 11:47:37 UTC) #4
eae
LGTM
3 years, 8 months ago (2017-04-06 12:10:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797313003/1
3 years, 8 months ago (2017-04-06 13:12:11 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 13:18:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0ab573d311cd7a4a72b86ee8d47a...

Powered by Google App Engine
This is Rietveld 408576698