Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: third_party/WebKit/Source/core/layout/ColumnBalancer.cpp

Issue 2797313003: Remove DCHECK in column balancer that failed because of flexbox bugs. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/nested-with-wrapped-flexbox-crash.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ColumnBalancer.cpp
diff --git a/third_party/WebKit/Source/core/layout/ColumnBalancer.cpp b/third_party/WebKit/Source/core/layout/ColumnBalancer.cpp
index d7aeba04b698b7273d75254f816f2b2ff43beaa6..69d72d477019728fbf13f591ec2721eaa9e49256 100644
--- a/third_party/WebKit/Source/core/layout/ColumnBalancer.cpp
+++ b/third_party/WebKit/Source/core/layout/ColumnBalancer.cpp
@@ -243,9 +243,6 @@ void InitialColumnHeightFinder::examineLine(const RootInlineBox& line) {
minimumLogialHeight += lineTopInFlowThread;
m_tallestUnbreakableLogicalHeight =
std::max(m_tallestUnbreakableLogicalHeight, minimumLogialHeight);
- DCHECK(
- isFirstAfterBreak(lineTopInFlowThread) || !line.paginationStrut() ||
- !isLogicalTopWithinBounds(lineTopInFlowThread - line.paginationStrut()));
if (isFirstAfterBreak(lineTopInFlowThread) &&
m_lastBreakSeen != lineTopInFlowThread) {
m_lastBreakSeen = lineTopInFlowThread;
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/nested-with-wrapped-flexbox-crash.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698