Turn off use-after-scope check on Mac.

Turn off use-after-scope check on Mac.

It was disabled in BUILD.gn, because there are known failures,
but recently Clang enabled it by default, so we have to opt out.

Eventually, we need to clean up these failures and reenable the
check as it's useful.

BUG=708216, 708707
Review-Url: https://codereview.chromium.org/2797253002
Cr-Commit-Position: refs/heads/master@{#462187}
Committed: https://chromium.googlesource.com/chromium/src/+/69faa6a6ffc1ceebf4d499618a5d17c8a1e7af67

[krasin1, 2017-04-05 18:15:26]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[krasin1, 2017-04-05 18:15:37]

krasin@chromium.org changed reviewers:
+ thakis@chromium.org

[commit-bot: I haz the power, 2017-04-05 18:16:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-04-05 18:20:28]

lgtm

I'd file a bug for the cleanup and add a TODO pointing to it in a comment next
to the -fno- flag.

Thanks!

[commit-bot: I haz the power, 2017-04-05 18:22:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 18:22:24]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[krasin1, 2017-04-05 18:36:22]

The CQ bit was checked by krasin@chromium.org

[krasin1, 2017-04-05 18:36:22]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2797253002/#ps20001
(title: "Add reference to a cleanup issue")

[krasin1, 2017-04-05 18:36:38]

Description was changed from

==========
Turn off use-after-scope check on Mac.

It was disabled in BUILD.gn, because there are known failures,
but recently Clang enabled it by default, so we have to opt out.

Eventually, we need to clean up these failures and reenable the
check as it's useful.

BUG=708216
==========

to

==========
Turn off use-after-scope check on Mac.

It was disabled in BUILD.gn, because there are known failures,
but recently Clang enabled it by default, so we have to opt out.

Eventually, we need to clean up these failures and reenable the
check as it's useful.

BUG=708216,708707
==========

[krasin1, 2017-04-05 18:36:48]

On 2017/04/05 18:20:28, Nico (afk until Tue Apr 4) wrote:
> lgtm
> 
> I'd file a bug for the cleanup and add a TODO pointing to it in a comment next
> to the -fno- flag.
> 
> Thanks!

Bug filed.

[commit-bot: I haz the power, 2017-04-05 18:37:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 19:48:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491417382009080,
"parent_rev": "d30d9afc9288d064df6fd9f12543ce5df8f351b5", "commit_rev":
"69faa6a6ffc1ceebf4d499618a5d17c8a1e7af67"}

[commit-bot: I haz the power, 2017-04-05 19:49:00]

Description was changed from

==========
Turn off use-after-scope check on Mac.

It was disabled in BUILD.gn, because there are known failures,
but recently Clang enabled it by default, so we have to opt out.

Eventually, we need to clean up these failures and reenable the
check as it's useful.

BUG=708216,708707
==========

to

==========
Turn off use-after-scope check on Mac.

It was disabled in BUILD.gn, because there are known failures,
but recently Clang enabled it by default, so we have to opt out.

Eventually, we need to clean up these failures and reenable the
check as it's useful.

BUG=708216,708707

Review-Url: https://codereview.chromium.org/2797253002
Cr-Commit-Position: refs/heads/master@{#462187}
Committed:
https://chromium.googlesource.com/chromium/src/+/69faa6a6ffc1ceebf4d499618a5d...
==========

[commit-bot: I haz the power, 2017-04-05 19:49:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/69faa6a6ffc1ceebf4d499618a5d...