Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: build/config/sanitizers/BUILD.gn

Issue 2797253002: Turn off use-after-scope check on Mac. (Closed)
Patch Set: Add reference to a cleanup issue Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/sanitizers/BUILD.gn
diff --git a/build/config/sanitizers/BUILD.gn b/build/config/sanitizers/BUILD.gn
index 2a6c578bcbd9c5a470cb2f8700eb0b264c8ae9b7..ddcb49f37e3099748dbc95fb87142ef8d69026aa 100644
--- a/build/config/sanitizers/BUILD.gn
+++ b/build/config/sanitizers/BUILD.gn
@@ -200,7 +200,10 @@ config("default_sanitizer_ldflags") {
ldflags = []
if (is_asan) {
ldflags += [ "-fsanitize=address" ]
- if (!is_mac) {
+ if (is_mac) {
+ # https://crbug.com/708707
+ ldflags += [ "-fno-sanitize-address-use-after-scope" ]
+ } else {
ldflags += [ "-fsanitize-address-use-after-scope" ]
}
}
@@ -314,6 +317,9 @@ config("asan_flags") {
cflags += [ "-fsanitize=address" ]
if (!is_mac && !is_win) {
cflags += [ "-fsanitize-address-use-after-scope" ]
+ } else {
+ # https://crbug.com/708707
+ cflags += [ "-fno-sanitize-address-use-after-scope" ]
}
if (!asan_globals) {
cflags += [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698