Document::hoverNode() is always an Element.

Document::hoverNode() is always an Element.

Make hoverNode(), hoverElement() and only mark Elements as hovered
using FlatTreeTraversal::parentElement() instead of parent(). This
means we can get rid of some checks for nodes being text or element
nodes. It means we also only mark elements as being hovered in the flat
tree ancestor chain.

R=ecobos@igalia.com

Review-Url: https://codereview.chromium.org/2797173002
Cr-Commit-Position: refs/heads/master@{#462257}
Committed: https://chromium.googlesource.com/chromium/src/+/5a7bb5e2821e5be66828f155ab71fb2c2738c7cb

[rune, 2017-04-05 10:55:49]

Description was changed from

==========
Document::hoverNode() is always an Element.

Make hoverNode(), hoverElement() and only mark Elements as hovered
using FlatTreeTraversal::parentElement() instead of parent(). This
means we can get rid of some checks for nodes being text or element
nodes. It means we also only mark elements as being hovered in the flat
tree ancestor chain.

R=ecobos@chromium.org
==========

to

==========
Document::hoverNode() is always an Element.

Make hoverNode(), hoverElement() and only mark Elements as hovered
using FlatTreeTraversal::parentElement() instead of parent(). This
means we can get rid of some checks for nodes being text or element
nodes. It means we also only mark elements as being hovered in the flat
tree ancestor chain.

R=ecobos@igalia.com
==========

[rune, 2017-04-05 10:55:49]

rune@opera.com changed reviewers:
+ ecobos@igalia.com
- ecobos@chromium.org

[rune, 2017-04-05 10:55:57]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 10:56:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 11:03:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 11:03:40]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[rune, 2017-04-05 11:38:13]

rune@opera.com changed reviewers:
+ rego@igalia.com

[emilio, 2017-04-05 12:38:50]

On 2017/04/05 11:38:13, rune wrote:

lgtm (though rego would need to sign-off too I guess).

I had something similar at https://codereview.chromium.org/2787943002/ :P

Thanks for doing this :)

[Manuel Rego, 2017-04-05 15:16:13]

lgtm

https://codereview.chromium.org/2797173002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/2797173002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/EventHandler.cpp:1502: // we should clear
the old hovered node from the old hovered frame.
Nit: Update the comment "the old hovered node".

[rune, 2017-04-05 19:43:28]

https://codereview.chromium.org/2797173002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/2797173002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/EventHandler.cpp:1502: // we should clear
the old hovered node from the old hovered frame.
On 2017/04/05 15:16:13, Manuel Rego wrote:
> Nit: Update the comment "the old hovered node".

Fixed another instance as well.

[rune, 2017-04-05 20:26:23]

The CQ bit was checked by rune@opera.com

[rune, 2017-04-05 20:26:23]

The patchset sent to the CQ was uploaded after l-g-t-m from rego@igalia.com,
ecobos@igalia.com
Link to the patchset: https://codereview.chromium.org/2797173002/#ps20001
(title: "Documentation hovered node -> hovered element.")

[commit-bot: I haz the power, 2017-04-05 20:27:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 23:07:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491423983333000,
"parent_rev": "5fa4cb0d7a1a784fec7991eaeb1a80e43f9156e5", "commit_rev":
"5a7bb5e2821e5be66828f155ab71fb2c2738c7cb"}

[commit-bot: I haz the power, 2017-04-05 23:08:47]

Description was changed from

==========
Document::hoverNode() is always an Element.

Make hoverNode(), hoverElement() and only mark Elements as hovered
using FlatTreeTraversal::parentElement() instead of parent(). This
means we can get rid of some checks for nodes being text or element
nodes. It means we also only mark elements as being hovered in the flat
tree ancestor chain.

R=ecobos@igalia.com
==========

to

==========
Document::hoverNode() is always an Element.

Make hoverNode(), hoverElement() and only mark Elements as hovered
using FlatTreeTraversal::parentElement() instead of parent(). This
means we can get rid of some checks for nodes being text or element
nodes. It means we also only mark elements as being hovered in the flat
tree ancestor chain.

R=ecobos@igalia.com

Review-Url: https://codereview.chromium.org/2797173002
Cr-Commit-Position: refs/heads/master@{#462257}
Committed:
https://chromium.googlesource.com/chromium/src/+/5a7bb5e2821e5be66828f155ab71...
==========

[commit-bot: I haz the power, 2017-04-05 23:08:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5a7bb5e2821e5be66828f155ab71...