Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2787943002: [WIP] Use the flat tree for hover handling.

Created:
3 years, 8 months ago by emilio
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, dtapuska+blinkwatch_chromium.org, sof, eae+blinkwatch, dcheng, blink-reviews-dom_chromium.org, dglazkov+blink, Navid Zolghadr, blink-reviews, kinuko+watch, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP] Use the flat tree for hover handling. Modulo spec debate like[1], this is much simpler and closer to the spec than what it was implemented. This doesn't actually fix issue 705984, but it's a required cleanup, and I've verified that the display: contents node is added to the :hover chain (if there's an intermediate <div>), so I probably need to investigate how hit testing and style invalidation is done, etc, to track down that bug. Still this is worth landing IMO. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -106 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/hover-active-drag.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/hover-active-drag-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 7 chunks +48 lines, -90 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 9 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
emilio
The CQ bit was checked by ecobos@igalia.com to run a CQ dry run
3 years, 8 months ago (2017-03-31 10:13:00 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787943002/1
3 years, 8 months ago (2017-03-31 10:13:11 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-03-31 11:44:15 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 11:44:16 UTC) #4
Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698