Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2797163005: MD Settings: CrOS: Users: Fix names (Closed)

Created:
3 years, 8 months ago by stevenjb
Modified:
3 years, 8 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, arv+watch_chromium.org, michaelpg+watch-md-ui_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, davemoore+watch_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: CrOS: Users: Fix names This CL: * Uses the correct display name for users. * Uses proper string substitution for l10n of owner user names. BUG=706333 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2797163005 Cr-Commit-Position: refs/heads/master@{#462548} Committed: https://chromium.googlesource.com/chromium/src/+/10c922d0770597a995a8609f40dd072c3521a96e

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -13 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/users_private/users_private_api.cc View 2 chunks +7 lines, -2 lines 2 comments Download
M chrome/browser/resources/settings/people_page/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/user_list.html View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/people_page/user_list.js View 1 4 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
stevenjb
3 years, 8 months ago (2017-04-06 02:26:46 UTC) #3
michaelpg
lgtm https://codereview.chromium.org/2797163005/diff/20001/chrome/browser/chromeos/extensions/users_private/users_private_api.cc File chrome/browser/chromeos/extensions/users_private/users_private_api.cc (right): https://codereview.chromium.org/2797163005/diff/20001/chrome/browser/chromeos/extensions/users_private/users_private_api.cc#newcode106 chrome/browser/chromeos/extensions/users_private/users_private_api.cc:106: // User is not associated with a gaia ...
3 years, 8 months ago (2017-04-06 14:50:29 UTC) #4
stevenjb
https://codereview.chromium.org/2797163005/diff/20001/chrome/browser/chromeos/extensions/users_private/users_private_api.cc File chrome/browser/chromeos/extensions/users_private/users_private_api.cc (right): https://codereview.chromium.org/2797163005/diff/20001/chrome/browser/chromeos/extensions/users_private/users_private_api.cc#newcode106 chrome/browser/chromeos/extensions/users_private/users_private_api.cc:106: // User is not associated with a gaia account. ...
3 years, 8 months ago (2017-04-06 16:27:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797163005/20001
3 years, 8 months ago (2017-04-06 16:33:31 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 18:18:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/10c922d0770597a995a8609f40dd...

Powered by Google App Engine
This is Rietveld 408576698