Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Unified Diff: chrome/browser/chromeos/extensions/users_private/users_private_api.cc

Issue 2797163005: MD Settings: CrOS: Users: Fix names (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/users_private/users_private_api.cc
diff --git a/chrome/browser/chromeos/extensions/users_private/users_private_api.cc b/chrome/browser/chromeos/extensions/users_private/users_private_api.cc
index 4026e98cdd6cec2e7c2148d92b4fc530b5695973..df92a3c216bec1f5a1a600c745f6199746439460 100644
--- a/chrome/browser/chromeos/extensions/users_private/users_private_api.cc
+++ b/chrome/browser/chromeos/extensions/users_private/users_private_api.cc
@@ -9,6 +9,7 @@
#include <utility>
#include "base/memory/ptr_util.h"
+#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chromeos/extensions/users_private/users_private_delegate.h"
@@ -99,8 +100,12 @@ UsersPrivateGetWhitelistedUsersFunction::Run() {
for (size_t i = 0; i < email_list->GetSize(); ++i) {
api::users_private::User user;
email_list->GetString(i, &user.email);
- user.name =
- user_manager->GetUserDisplayEmail(AccountId::FromUserEmail(user.email));
+ AccountId account_id = AccountId::FromUserEmail(user.email);
+ user.name = base::UTF16ToUTF8(user_manager->GetUserDisplayName(account_id));
+ if (user.name.empty()) {
+ // User is not associated with a gaia account.
michaelpg 2017/04/06 14:50:29 what cases don't have gaia accounts or display nam
stevenjb 2017/04/06 16:27:58 I'm not really sure, just making sure we are consi
+ user.name = user_manager->GetUserDisplayEmail(account_id);
+ }
user.is_owner = chromeos::ProfileHelper::IsOwnerProfile(profile) &&
user.email == profile->GetProfileUserName();
user_list->Append(user.ToValue());
« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/people_page/compiled_resources2.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698