Pass file name when downloading OMA DRM files

Pass file name when downloading OMA DRM files

When downloading a OMA DRM file, currently we use Android DownloadManager
to generate the file path.
This is because the Android DM may rename the file.
However, the Android DownloadManager will by default save the file to an
internal directory, which cannot be accessed by other apps.
This CL passes the file name from native to Android DownloadManager.
So the file path generation will be determined by Chrome.
This change also fixes the problem of openning a DRM download from snackbar.
Instead of openning download home, this CL will open the Downloads app instead.

BUG=708172
Review-Url: https://codereview.chromium.org/2797003002
Cr-Commit-Position: refs/heads/master@{#461906}
Committed: https://chromium.googlesource.com/chromium/src/+/b226550dbd1834c2f7addec9d1df7d57498fb7fc

[qinmin, 2017-04-04 18:46:01]

qinmin@chromium.org changed reviewers:
+ dtrainor@chromium.org

[qinmin, 2017-04-04 18:46:02]

dtrainor@, this is a stable blocker, PTAL

[David Trainor- moved to gerrit, 2017-04-04 19:24:12]

lgtm

https://codereview.chromium.org/2797003002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
(right):

https://codereview.chromium.org/2797003002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java:35:
boolean usesAndroidDownloadmanager) {
manager -> Manager?

[qinmin, 2017-04-04 22:20:44]

https://codereview.chromium.org/2797003002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
(right):

https://codereview.chromium.org/2797003002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java:35:
boolean usesAndroidDownloadmanager) {
On 2017/04/04 19:24:12, David Trainor-ping if over 24h wrote:
> manager -> Manager?

Done.

[qinmin, 2017-04-04 22:20:59]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2017-04-04 22:21:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2797003002/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2017-04-04 22:21:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 00:00:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491344459746900,
"parent_rev": "5ddd95b27edcc71d172b5985c3c9c84fd93435a5", "commit_rev":
"b226550dbd1834c2f7addec9d1df7d57498fb7fc"}

[commit-bot: I haz the power, 2017-04-05 00:01:12]

Description was changed from

==========
Pass file name when downloading OMA DRM files

When downloading a OMA DRM file, currently we use Android DownloadManager
to generate the file path.
This is because the Android DM may rename the file.
However, the Android DownloadManager will by default save the file to an
internal directory, which cannot be accessed by other apps.
This CL passes the file name from native to Android DownloadManager.
So the file path generation will be determined by Chrome.
This change also fixes the problem of openning a DRM download from snackbar.
Instead of openning download home, this CL will open the Downloads app instead.

BUG=708172
==========

to

==========
Pass file name when downloading OMA DRM files

When downloading a OMA DRM file, currently we use Android DownloadManager
to generate the file path.
This is because the Android DM may rename the file.
However, the Android DownloadManager will by default save the file to an
internal directory, which cannot be accessed by other apps.
This CL passes the file name from native to Android DownloadManager.
So the file path generation will be determined by Chrome.
This change also fixes the problem of openning a DRM download from snackbar.
Instead of openning download home, this CL will open the Downloads app instead.

BUG=708172

Review-Url: https://codereview.chromium.org/2797003002
Cr-Commit-Position: refs/heads/master@{#461906}
Committed:
https://chromium.googlesource.com/chromium/src/+/b226550dbd1834c2f7addec9d1df...
==========

[commit-bot: I haz the power, 2017-04-05 00:01:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b226550dbd1834c2f7addec9d1df...