chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java - Issue 2797003002: Pass file name when downloading OMA DRM files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java

Issue 2797003002: Pass file name when downloading OMA DRM files (Closed)

Patch Set: nit Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java

index a1680cada2f735ba54f87264fa37c5f252ed9cdb..699132e013943e1d58a29da519e15e8c73a67001 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java

@@ -216,15 +216,12 @@ public class DownloadManagerDelegate {

int status = c.getInt(c.getColumnIndex(DownloadManager.COLUMN_STATUS));

if (status == DownloadManager.STATUS_SUCCESSFUL) {

downloadStatus = DownloadManagerService.DOWNLOAD_STATUS_COMPLETE;

- if (mDownloadItem.getDownloadInfo().getFileName() == null) {

- DownloadInfo info =

- DownloadInfo.Builder

- .fromDownloadInfo(mDownloadItem.getDownloadInfo())

- .setFileName(c.getString(

- c.getColumnIndex(DownloadManager.COLUMN_TITLE)))

- .build();

- mDownloadItem.setDownloadInfo(info);

- }

+ DownloadInfo info =

+ DownloadInfo.Builder.fromDownloadInfo(mDownloadItem.getDownloadInfo())

+ .setFileName(c.getString(

+ c.getColumnIndex(DownloadManager.COLUMN_TITLE)))

+ .build();

+ mDownloadItem.setDownloadInfo(info);

if (mShowNotifications) {

canResolve = DownloadManagerService.isOMADownloadDescription(

mDownloadItem.getDownloadInfo())