Move routing token out of AndroidOverlay config.

Move routing token out of AndroidOverlay config.

This CL removes the routing token from the AndroidOverlay initial
config struct.  It does not remove it from the mojo version of the
config, since it's now an implementation detail for mojo.

After this CL, the routing config will be provided to the mojo
factory.  The application won't need to remember it.

BUG=

Review-Url: https://codereview.chromium.org/2796943002
Cr-Commit-Position: refs/heads/master@{#461859}
Committed: https://chromium.googlesource.com/chromium/src/+/29aa3bc7a1fb3b50e9610e35be6eb052f60e4696

[liberato (no reviews please), 2017-04-04 15:57:33]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 15:58:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 17:12:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 17:12:22]

Dry run: This issue passed the CQ dry run.

[liberato (no reviews please), 2017-04-04 17:35:18]

Description was changed from

==========
Move routing token out of AndroidOverlay config.

This CL removes the routing token from the AndroidOverlay initial
config struct.  It does not remove it from the mojo version of the
config, since it's now an implementation detail for mojo.

After this CL, the routing config will be provided to the mojo
factory.  The application won't need to remember it.

BUG=
==========

to

==========
Move routing token out of AndroidOverlay config.

This CL removes the routing token from the AndroidOverlay initial
config struct.  It does not remove it from the mojo version of the
config, since it's now an implementation detail for mojo.

After this CL, the routing config will be provided to the mojo
factory.  The application won't need to remember it.

BUG=
==========

[liberato (no reviews please), 2017-04-04 17:35:18]

liberato@chromium.org changed reviewers:
+ dalecurtis@chromium.org, dcheng@chromium.org

[liberato (no reviews please), 2017-04-04 17:39:51]

it occurs to me that the routing token can be kept as an implementation detail
of the mojo impl, rather than sending it around in the generic
AndroidOverlay::Config structure.  hiding it in the factory makes it much nicer
for the application code that uses it.

it stays in the mojo version of the config struct.

found this out while modifying AndroidVideoDecodeAccelerator.

i should have realized that earlier.

thanks
-fl

[DaleCurtis, 2017-04-04 18:48:22]

lgtm % minor changes

https://codereview.chromium.org/2796943002/diff/1/media/mojo/clients/mojo_and...
File media/mojo/clients/mojo_android_overlay.h (right):

https://codereview.chromium.org/2796943002/diff/1/media/mojo/clients/mojo_and...
media/mojo/clients/mojo_android_overlay.h:29: const base::UnguessableToken&
routing_token);
Should probably add a move constructor for this, but current syntax is fine.

https://codereview.chromium.org/2796943002/diff/1/media/mojo/clients/mojo_and...
File media/mojo/clients/mojo_android_overlay_factory.h (right):

https://codereview.chromium.org/2796943002/diff/1/media/mojo/clients/mojo_and...
media/mojo/clients/mojo_android_overlay_factory.h:26: const
base::UnguessableToken& routing_token);
Input only parameters before input/output ones.

[liberato (no reviews please), 2017-04-04 20:00:01]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[liberato (no reviews please), 2017-04-04 20:00:21]

thanks for the feedback.

-fl

https://codereview.chromium.org/2796943002/diff/1/media/mojo/clients/mojo_and...
File media/mojo/clients/mojo_android_overlay.h (right):

https://codereview.chromium.org/2796943002/diff/1/media/mojo/clients/mojo_and...
media/mojo/clients/mojo_android_overlay.h:29: const base::UnguessableToken&
routing_token);
On 2017/04/04 18:48:21, DaleCurtis wrote:
> Should probably add a move constructor for this, but current syntax is fine.

UG has no movable data, so i omitted it.

or did you mean MojoAndroidOverlay?

https://codereview.chromium.org/2796943002/diff/1/media/mojo/clients/mojo_and...
File media/mojo/clients/mojo_android_overlay_factory.h (right):

https://codereview.chromium.org/2796943002/diff/1/media/mojo/clients/mojo_and...
media/mojo/clients/mojo_android_overlay_factory.h:26: const
base::UnguessableToken& routing_token);
On 2017/04/04 18:48:21, DaleCurtis wrote:
> Input only parameters before input/output ones.

Done.

[commit-bot: I haz the power, 2017-04-04 20:01:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[DaleCurtis, 2017-04-04 20:14:55]

https://codereview.chromium.org/2796943002/diff/1/media/mojo/clients/mojo_and...
File media/mojo/clients/mojo_android_overlay.h (right):

https://codereview.chromium.org/2796943002/diff/1/media/mojo/clients/mojo_and...
media/mojo/clients/mojo_android_overlay.h:29: const base::UnguessableToken&
routing_token);
On 2017/04/04 at 20:00:21, liberato wrote:
> On 2017/04/04 18:48:21, DaleCurtis wrote:
> > Should probably add a move constructor for this, but current syntax is fine.
> 
> UG has no movable data, so i omitted it.
> 
> or did you mean MojoAndroidOverlay?

Meant UG should get a move constructor (in another CL).

[commit-bot: I haz the power, 2017-04-04 21:24:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 21:24:15]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-04-04 21:48:27]

LGTM

[liberato (no reviews please), 2017-04-04 21:50:40]

The CQ bit was checked by liberato@chromium.org

[liberato (no reviews please), 2017-04-04 21:50:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2796943002/#ps20001
(title: "cl feedback 1/2")

[commit-bot: I haz the power, 2017-04-04 21:51:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 22:02:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491342640420390,
"parent_rev": "d27468a832d5316884bd02f459cbf493697fd7e1", "commit_rev":
"29aa3bc7a1fb3b50e9610e35be6eb052f60e4696"}

[commit-bot: I haz the power, 2017-04-04 22:03:48]

Description was changed from

==========
Move routing token out of AndroidOverlay config.

This CL removes the routing token from the AndroidOverlay initial
config struct.  It does not remove it from the mojo version of the
config, since it's now an implementation detail for mojo.

After this CL, the routing config will be provided to the mojo
factory.  The application won't need to remember it.

BUG=
==========

to

==========
Move routing token out of AndroidOverlay config.

This CL removes the routing token from the AndroidOverlay initial
config struct.  It does not remove it from the mojo version of the
config, since it's now an implementation detail for mojo.

After this CL, the routing config will be provided to the mojo
factory.  The application won't need to remember it.

BUG=

Review-Url: https://codereview.chromium.org/2796943002
Cr-Commit-Position: refs/heads/master@{#461859}
Committed:
https://chromium.googlesource.com/chromium/src/+/29aa3bc7a1fb3b50e9610e35be6e...
==========

[commit-bot: I haz the power, 2017-04-04 22:03:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/29aa3bc7a1fb3b50e9610e35be6e...