Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: media/mojo/clients/mojo_android_overlay.h

Issue 2796943002: Move routing token out of AndroidOverlay config. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_BASE_MOJO_ANDROID_OVERLAY_H_ 5 #ifndef MEDIA_BASE_MOJO_ANDROID_OVERLAY_H_
6 #define MEDIA_BASE_MOJO_ANDROID_OVERLAY_H_ 6 #define MEDIA_BASE_MOJO_ANDROID_OVERLAY_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/unguessable_token.h"
9 #include "media/base/android/android_overlay.h" 10 #include "media/base/android/android_overlay.h"
10 #include "media/mojo/interfaces/android_overlay.mojom.h" 11 #include "media/mojo/interfaces/android_overlay.mojom.h"
11 #include "mojo/public/cpp/bindings/binding.h" 12 #include "mojo/public/cpp/bindings/binding.h"
12 13
13 namespace service_manager { 14 namespace service_manager {
14 namespace mojom { 15 namespace mojom {
15 class InterfaceProvider; 16 class InterfaceProvider;
16 } 17 }
17 } 18 }
18 19
19 namespace media { 20 namespace media {
20 21
21 // AndroidOverlay implementation via mojo. 22 // AndroidOverlay implementation via mojo.
22 class MojoAndroidOverlay : public AndroidOverlay, 23 class MojoAndroidOverlay : public AndroidOverlay,
23 public mojom::AndroidOverlayClient { 24 public mojom::AndroidOverlayClient {
24 public: 25 public:
25 MojoAndroidOverlay( 26 MojoAndroidOverlay(
26 service_manager::mojom::InterfaceProvider* interface_provider, 27 service_manager::mojom::InterfaceProvider* interface_provider,
27 const AndroidOverlay::Config& config); 28 const AndroidOverlay::Config& config,
29 const base::UnguessableToken& routing_token);
DaleCurtis 2017/04/04 18:48:21 Should probably add a move constructor for this, b
liberato (no reviews please) 2017/04/04 20:00:21 UG has no movable data, so i omitted it. or did y
DaleCurtis 2017/04/04 20:14:55 Meant UG should get a move constructor (in another
28 30
29 ~MojoAndroidOverlay() override; 31 ~MojoAndroidOverlay() override;
30 32
31 // AndroidOverlay 33 // AndroidOverlay
32 void ScheduleLayout(const gfx::Rect& rect) override; 34 void ScheduleLayout(const gfx::Rect& rect) override;
33 const base::android::JavaRef<jobject>& GetJavaSurface() const override; 35 const base::android::JavaRef<jobject>& GetJavaSurface() const override;
34 36
35 // mojom::AndroidOverlayClient 37 // mojom::AndroidOverlayClient
36 void OnSurfaceReady(uint64_t surface_key) override; 38 void OnSurfaceReady(uint64_t surface_key) override;
37 void OnDestroyed() override; 39 void OnDestroyed() override;
38 40
39 private: 41 private:
40 service_manager::mojom::InterfaceProvider* interface_provider_; 42 service_manager::mojom::InterfaceProvider* interface_provider_;
41 AndroidOverlay::Config config_; 43 AndroidOverlay::Config config_;
42 mojom::AndroidOverlayProviderPtr provider_ptr_; 44 mojom::AndroidOverlayProviderPtr provider_ptr_;
43 mojom::AndroidOverlayPtr overlay_ptr_; 45 mojom::AndroidOverlayPtr overlay_ptr_;
44 std::unique_ptr<mojo::Binding<mojom::AndroidOverlayClient>> binding_; 46 std::unique_ptr<mojo::Binding<mojom::AndroidOverlayClient>> binding_;
45 gl::ScopedJavaSurface surface_; 47 gl::ScopedJavaSurface surface_;
46 48
47 // Have we received OnSurfaceReady yet? 49 // Have we received OnSurfaceReady yet?
48 bool received_surface_ = false; 50 bool received_surface_ = false;
49 51
50 DISALLOW_COPY_AND_ASSIGN(MojoAndroidOverlay); 52 DISALLOW_COPY_AND_ASSIGN(MojoAndroidOverlay);
51 }; 53 };
52 54
53 } // namespace media 55 } // namespace media
54 56
55 #endif // MEDIA_BASE_MOJO_ANDROID_OVERLAY_H_ 57 #endif // MEDIA_BASE_MOJO_ANDROID_OVERLAY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698