Update text field 'change' event logic to match to Firefox.

Update text field 'change' event logic to match to Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior in many more cases, and our understanding
is that:

A) Initialize last-value with null.
B) On every user edit, set the value before the edit to last-value if it is null.
C) On every user edit, set last-value to null if it and the new value are same.
D) Dispatch CHANGE event if last-value is not null and it and the current value
  are not same.

TextControlElement::m_valueBeforeFirstUserEdit represents last-value.
TextControlElement::setValueBeforeFirstUserEditIfNotSet() represents B, and
TestControlElement::checkIfValueWasReverted() represents C.  This CL adds them to
every code path updating value by user edit.

BUG=706370
Review-Url: https://codereview.chromium.org/2796853002
Cr-Commit-Position: refs/heads/master@{#462349}
Committed: https://chromium.googlesource.com/chromium/src/+/90b048661a3949cd38ef690052d6930c230b4100

[tkent, 2017-04-05 11:12:36]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 11:12:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 12:22:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 12:22:58]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tkent, 2017-04-05 13:17:58]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 13:18:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 14:35:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 14:35:13]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-04-05 22:49:42]

Patchset #1 (id:1) has been deleted

[tkent, 2017-04-05 22:49:47]

Patchset #1 (id:20001) has been deleted

[tkent, 2017-04-05 22:49:52]

Patchset #1 (id:40001) has been deleted

[tkent, 2017-04-06 02:01:59]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 02:02:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-04-06 02:16:39]

Description was changed from

==========
Update 'change' event rules to match Firefox.

WIP

BUG=706370
==========

to

==========
Update text field 'change' event logic to match Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior more, and our understanding is that:

- Initialize m_valueBeforeFirstUserEdit with null.
- On every user edit, set the value before the edit to
m_valueBeforeFirstUserEdit
  if it is null.
- On every user edit, set m_valueBeforeFirstUserEdit to null if it and the new
  value are same.
- Dispatch CHANGE event if m_valueBeforeFirstUserEdit is not null and it and the
  current value are not same.


BUG=706370
==========

[tkent, 2017-04-06 02:19:08]

Description was changed from

==========
Update text field 'change' event logic to match Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior more, and our understanding is that:

- Initialize m_valueBeforeFirstUserEdit with null.
- On every user edit, set the value before the edit to
m_valueBeforeFirstUserEdit
  if it is null.
- On every user edit, set m_valueBeforeFirstUserEdit to null if it and the new
  value are same.
- Dispatch CHANGE event if m_valueBeforeFirstUserEdit is not null and it and the
  current value are not same.


BUG=706370
==========

to

==========
Update text field 'change' event logic to match Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior more, and our understanding is that:

A) Initialize m_valueBeforeFirstUserEdit with null.
B) On every user edit, set the value before the edit to
m_valueBeforeFirstUserEdit
  if it is null.
C) On every user edit, set m_valueBeforeFirstUserEdit to null if it and the new
  value are same.
D) Dispatch CHANGE event if m_valueBeforeFirstUserEdit is not null and it and
the
  current value are not same.

TextControlElement::setValueBeforeFirstUserEditIfNotSet() represents B, and
TestControlElement::checkIfValueWasReverted() represents C.
This CL adds them to every code path updating value by user edit.

BUG=706370
==========

[tkent, 2017-04-06 02:21:20]

Description was changed from

==========
Update text field 'change' event logic to match Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior more, and our understanding is that:

A) Initialize m_valueBeforeFirstUserEdit with null.
B) On every user edit, set the value before the edit to
m_valueBeforeFirstUserEdit
  if it is null.
C) On every user edit, set m_valueBeforeFirstUserEdit to null if it and the new
  value are same.
D) Dispatch CHANGE event if m_valueBeforeFirstUserEdit is not null and it and
the
  current value are not same.

TextControlElement::setValueBeforeFirstUserEditIfNotSet() represents B, and
TestControlElement::checkIfValueWasReverted() represents C.
This CL adds them to every code path updating value by user edit.

BUG=706370
==========

to

==========
Update text field 'change' event logic to match Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior more, and our understanding is that:

A) Initialize m_valueBeforeFirstUserEdit with null.
B) On every user edit, set the value before the edit to
m_valueBeforeFirstUserEdit
  if it is null.
C) On every user edit, set m_valueBeforeFirstUserEdit to null if it and the new
  value are same.
D) Dispatch CHANGE event if m_valueBeforeFirstUserEdit is not null and it and
the
  current value are not same.

TextControlElement::setValueBeforeFirstUserEditIfNotSet() represents B, and
TestControlElement::checkIfValueWasReverted() represents C.
This CL adds them to every code path updating value by user edit.

We can remove many callsites of setTextAsOfLastFormControlChangeEvent() because
such value is 

BUG=706370
==========

[tkent, 2017-04-06 02:22:20]

Description was changed from

==========
Update text field 'change' event logic to match Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior more, and our understanding is that:

A) Initialize m_valueBeforeFirstUserEdit with null.
B) On every user edit, set the value before the edit to
m_valueBeforeFirstUserEdit
  if it is null.
C) On every user edit, set m_valueBeforeFirstUserEdit to null if it and the new
  value are same.
D) Dispatch CHANGE event if m_valueBeforeFirstUserEdit is not null and it and
the
  current value are not same.

TextControlElement::setValueBeforeFirstUserEditIfNotSet() represents B, and
TestControlElement::checkIfValueWasReverted() represents C.
This CL adds them to every code path updating value by user edit.

We can remove many callsites of setTextAsOfLastFormControlChangeEvent() because
such value is 

BUG=706370
==========

to

==========
Update text field 'change' event logic to match Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior more, and our understanding is that:

A) Initialize m_valueBeforeFirstUserEdit with null.
B) On every user edit, set the value before the edit to
m_valueBeforeFirstUserEdit
  if it is null.
C) On every user edit, set m_valueBeforeFirstUserEdit to null if it and the new
  value are same.
D) Dispatch CHANGE event if m_valueBeforeFirstUserEdit is not null and it and
the
  current value are not same.

TextControlElement::setValueBeforeFirstUserEditIfNotSet() represents B, and
TestControlElement::checkIfValueWasReverted() represents C.
This CL adds them to every code path updating value by user edit.

BUG=706370
==========

[tkent, 2017-04-06 02:23:22]

Description was changed from

==========
Update text field 'change' event logic to match Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior more, and our understanding is that:

A) Initialize m_valueBeforeFirstUserEdit with null.
B) On every user edit, set the value before the edit to
m_valueBeforeFirstUserEdit
  if it is null.
C) On every user edit, set m_valueBeforeFirstUserEdit to null if it and the new
  value are same.
D) Dispatch CHANGE event if m_valueBeforeFirstUserEdit is not null and it and
the
  current value are not same.

TextControlElement::setValueBeforeFirstUserEditIfNotSet() represents B, and
TestControlElement::checkIfValueWasReverted() represents C.
This CL adds them to every code path updating value by user edit.

BUG=706370
==========

to

==========
Update text field 'change' event logic to match Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior in many more cases, and our understanding
is that:

A) Initialize m_valueBeforeFirstUserEdit with null.
B) On every user edit, set the value before the edit to
m_valueBeforeFirstUserEdit
  if it is null.
C) On every user edit, set m_valueBeforeFirstUserEdit to null if it and the new
  value are same.
D) Dispatch CHANGE event if m_valueBeforeFirstUserEdit is not null and it and
the
  current value are not same.

TextControlElement::setValueBeforeFirstUserEditIfNotSet() represents B, and
TestControlElement::checkIfValueWasReverted() represents C.
This CL adds them to every code path updating value by user edit.

BUG=706370
==========

[commit-bot: I haz the power, 2017-04-06 03:21:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 03:21:04]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-04-06 03:33:11]

Description was changed from

==========
Update text field 'change' event logic to match Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior in many more cases, and our understanding
is that:

A) Initialize m_valueBeforeFirstUserEdit with null.
B) On every user edit, set the value before the edit to
m_valueBeforeFirstUserEdit
  if it is null.
C) On every user edit, set m_valueBeforeFirstUserEdit to null if it and the new
  value are same.
D) Dispatch CHANGE event if m_valueBeforeFirstUserEdit is not null and it and
the
  current value are not same.

TextControlElement::setValueBeforeFirstUserEditIfNotSet() represents B, and
TestControlElement::checkIfValueWasReverted() represents C.
This CL adds them to every code path updating value by user edit.

BUG=706370
==========

to

==========
Update text field 'change' event logic to match to Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior in many more cases, and our understanding
is that:

A) Initialize m_valueBeforeFirstUserEdit with null.
B) On every user edit, set the value before the edit to
m_valueBeforeFirstUserEdit
  if it is null.
C) On every user edit, set m_valueBeforeFirstUserEdit to null if it and the new
  value are same.
D) Dispatch CHANGE event if m_valueBeforeFirstUserEdit is not null and it and
the
  current value are not same.

TextControlElement::setValueBeforeFirstUserEditIfNotSet() represents B, and
TestControlElement::checkIfValueWasReverted() represents C.
This CL adds them to every code path updating value by user edit.

BUG=706370
==========

[tkent, 2017-04-06 03:35:05]

Description was changed from

==========
Update text field 'change' event logic to match to Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior in many more cases, and our understanding
is that:

A) Initialize m_valueBeforeFirstUserEdit with null.
B) On every user edit, set the value before the edit to
m_valueBeforeFirstUserEdit
  if it is null.
C) On every user edit, set m_valueBeforeFirstUserEdit to null if it and the new
  value are same.
D) Dispatch CHANGE event if m_valueBeforeFirstUserEdit is not null and it and
the
  current value are not same.

TextControlElement::setValueBeforeFirstUserEditIfNotSet() represents B, and
TestControlElement::checkIfValueWasReverted() represents C.
This CL adds them to every code path updating value by user edit.

BUG=706370
==========

to

==========
Update text field 'change' event logic to match to Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior in many more cases, and our understanding
is that:

A) Initialize last-value with null.
B) On every user edit, set the value before the edit to last-value if it is
null.
C) On every user edit, set last-value to null if it and the new value are same.
D) Dispatch CHANGE event if last-value is not null and it and the current value
  are not same.

TextControlElement::m_valueBeforeFirstUserEdit represents last-value.
TextControlElement::setValueBeforeFirstUserEditIfNotSet() represents B, and
TestControlElement::checkIfValueWasReverted() represents C.
This CL adds them to every code path updating value by user edit.

BUG=706370
==========

[tkent, 2017-04-06 03:37:31]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2017-04-06 03:37:31]

keishi@, would you review this please?

kochi@, yosin@, FYI.  My CLs in last few days were preparations for this.

[tkent, 2017-04-06 03:39:17]

Description was changed from

==========
Update text field 'change' event logic to match to Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior in many more cases, and our understanding
is that:

A) Initialize last-value with null.
B) On every user edit, set the value before the edit to last-value if it is
null.
C) On every user edit, set last-value to null if it and the new value are same.
D) Dispatch CHANGE event if last-value is not null and it and the current value
  are not same.

TextControlElement::m_valueBeforeFirstUserEdit represents last-value.
TextControlElement::setValueBeforeFirstUserEditIfNotSet() represents B, and
TestControlElement::checkIfValueWasReverted() represents C.
This CL adds them to every code path updating value by user edit.

BUG=706370
==========

to

==========
Update text field 'change' event logic to match to Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior in many more cases, and our understanding
is that:

A) Initialize last-value with null.
B) On every user edit, set the value before the edit to last-value if it is
null.
C) On every user edit, set last-value to null if it and the new value are same.
D) Dispatch CHANGE event if last-value is not null and it and the current value
  are not same.

TextControlElement::m_valueBeforeFirstUserEdit represents last-value.
TextControlElement::setValueBeforeFirstUserEditIfNotSet() represents B, and
TestControlElement::checkIfValueWasReverted() represents C.  This CL adds them
to
every code path updating value by user edit.

BUG=706370
==========

[keishi, 2017-04-06 03:59:38]

LGTM

[tkent, 2017-04-06 04:09:14]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-04-06 04:09:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 04:13:47]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491451754618650,
"parent_rev": "dd3c9a967d856c4dc8b41fc1738caa4c035c6b82", "commit_rev":
"90b048661a3949cd38ef690052d6930c230b4100"}

[commit-bot: I haz the power, 2017-04-06 04:14:38]

Description was changed from

==========
Update text field 'change' event logic to match to Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior in many more cases, and our understanding
is that:

A) Initialize last-value with null.
B) On every user edit, set the value before the edit to last-value if it is
null.
C) On every user edit, set last-value to null if it and the new value are same.
D) Dispatch CHANGE event if last-value is not null and it and the current value
  are not same.

TextControlElement::m_valueBeforeFirstUserEdit represents last-value.
TextControlElement::setValueBeforeFirstUserEditIfNotSet() represents B, and
TestControlElement::checkIfValueWasReverted() represents C.  This CL adds them
to
every code path updating value by user edit.

BUG=706370
==========

to

==========
Update text field 'change' event logic to match to Firefox.

We tried to do so by r430531, but it was incomplete.
We investigated Firefox behavior in many more cases, and our understanding
is that:

A) Initialize last-value with null.
B) On every user edit, set the value before the edit to last-value if it is
null.
C) On every user edit, set last-value to null if it and the new value are same.
D) Dispatch CHANGE event if last-value is not null and it and the current value
  are not same.

TextControlElement::m_valueBeforeFirstUserEdit represents last-value.
TextControlElement::setValueBeforeFirstUserEditIfNotSet() represents B, and
TestControlElement::checkIfValueWasReverted() represents C.  This CL adds them
to
every code path updating value by user edit.

BUG=706370

Review-Url: https://codereview.chromium.org/2796853002
Cr-Commit-Position: refs/heads/master@{#462349}
Committed:
https://chromium.googlesource.com/chromium/src/+/90b048661a3949cd38ef690052d6...
==========

[commit-bot: I haz the power, 2017-04-06 04:14:39]

Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/90b048661a3949cd38ef690052d6...