Update text field 'change' event logic to match to Firefox.

third_party/WebKit/Source/core/html/HTMLInputElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
  * rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2008 Torch Mobile Inc. All rights reserved.
@@ skipping 369 matching lines @@
   if (m_inputType->valueMode() == ValueMode::kValue)
     m_nonAttributeValue = sanitizeValue(defaultValue);
   ensureUserAgentShadowRoot();
 
   setNeedsWillValidateCheck();
 
   if (!defaultValue.isNull())
     m_inputType->warnIfValueIsInvalid(defaultValue);
 
   m_inputTypeView->updateView();
-  setTextAsOfLastFormControlChangeEvent(value());
-  setChangedSinceLastFormControlChangeEvent(false);
 }
 
 void HTMLInputElement::updateType() {
   DCHECK(m_inputType);
   DCHECK(m_inputTypeView);
 
   const AtomicString& newTypeName =
       InputType::normalizeTypeName(fastGetAttribute(typeAttr));
   if (m_inputType->formControlType() == newTypeName)
     return;
@@ skipping 95 matching lines @@
           AttributeModificationParams(alignAttr, align->value(), align->value(),
                                       AttributeModificationReason::kDirectly));
     }
   }
 
   // UA Shadow tree was recreated. We need to set selection again. We do it
   // later in order to avoid force layout.
   if (document().focusedElement() == this)
     document().updateFocusAppearanceLater();
 
-  setTextAsOfLastFormControlChangeEvent(value());
-  setChangedSinceLastFormControlChangeEvent(false);
+  // TODO(tkent): Should we dispatch a change event?
+  clearValueBeforeFirstUserEdit();
 
   addToRadioButtonGroup();
 
   setNeedsValidityCheck();
   if ((couldBeSuccessfulSubmitButton || canBeSuccessfulSubmitButton()) &&
       formOwner() && isConnected())
     formOwner()->invalidateDefaultButtonStyle();
   notifyFormStateChanged();
 }
 
@@ skipping 187 matching lines @@
         m_autocomplete = Uninitialized;
       else
         m_autocomplete = On;
     }
   } else if (name == typeAttr) {
     updateType();
   } else if (name == valueAttr) {
     // We only need to setChanged if the form is looking at the default value
     // right now.
     if (!hasDirtyValue()) {
-      if (m_inputType->valueMode() == ValueMode::kValue) {
+      if (m_inputType->valueMode() == ValueMode::kValue)
         m_nonAttributeValue = sanitizeValue(value);
-        setTextAsOfLastFormControlChangeEvent(m_nonAttributeValue);
-      }
       updatePlaceholderVisibility();
       setNeedsStyleRecalc(
           SubtreeStyleChange,
           StyleChangeReasonForTracing::fromAttribute(valueAttr));
     }
     m_needsToUpdateViewValue = true;
     setNeedsValidityCheck();
     m_valueAttributeWasUpdatedAfterParsing = !m_parsingInProgress;
     m_inputType->warnIfValueIsInvalidAndElementIsVisible(value);
     m_inputType->inRangeChanged();
@@ skipping 215 matching lines @@
       cache->checkedStateChanged(this);
   }
 
   // Only send a change event for items in the document (avoid firing during
   // parsing) and don't send a change event for a radio button that's getting
   // unchecked to match other browsers. DOM is not a useful standard for this
   // because it says only to fire change events at "lose focus" time, which is
   // definitely wrong in practice for these types of elements.
   if (eventBehavior != DispatchNoEvent && isConnected() &&
       m_inputType->shouldSendChangeEventAfterCheckedChanged()) {
-    setTextAsOfLastFormControlChangeEvent(String());
     if (eventBehavior == DispatchInputAndChangeEvent)
       dispatchFormControlInputEvent();
   }
 
   pseudoStateChanged(CSSSelector::PseudoChecked);
 }
 
 void HTMLInputElement::setIndeterminate(bool newValue) {
   if (indeterminate() == newValue)
     return;
@@ skipping 132 matching lines @@
 
 void HTMLInputElement::setNonAttributeValue(const String& sanitizedValue) {
   // This is a common code for ValueMode::kValue.
   DCHECK_EQ(m_inputType->valueMode(), ValueMode::kValue);
   m_nonAttributeValue = sanitizedValue;
   m_hasDirtyValue = true;
   setNeedsValidityCheck();
   m_inputType->inRangeChanged();
 }
 
+void HTMLInputElement::setNonAttributeValueByUserEdit(
+    const String& sanitizedValue) {
+  setValueBeforeFirstUserEditIfNotSet();
+  setNonAttributeValue(sanitizedValue);
+  checkIfValueWasReverted(sanitizedValue);
+}
+
 void HTMLInputElement::setNonDirtyValue(const String& newValue) {
   setValue(newValue);
   m_hasDirtyValue = false;
 }
 
 bool HTMLInputElement::hasDirtyValue() const {
   return m_hasDirtyValue;
 }
 
 void HTMLInputElement::updateView() {
@@ skipping 32 matching lines @@
   // File upload controls will never use this.
   DCHECK_NE(type(), InputTypeNames::file);
 
   m_suggestedValue = String();
 
   // Renderer and our event handler are responsible for sanitizing values.
   DCHECK(value == m_inputType->sanitizeUserInputValue(value) ||
          m_inputType->sanitizeUserInputValue(value).isEmpty());
 
   DCHECK(!value.isNull());
+  setValueBeforeFirstUserEditIfNotSet();
   m_nonAttributeValue = value;
   m_hasDirtyValue = true;
   m_needsToUpdateViewValue = false;
+  checkIfValueWasReverted(value);
 
   // Input event is fired by the Node::defaultEventHandler for editable
   // controls.
   if (!isTextField())
     dispatchInputEvent();
   notifyFormStateChanged();
 
   setNeedsValidityCheck();
 
   // Clear autofill flag (and yellow background) on user edit.
@@ skipping 80 matching lines @@
 
   if (m_inputTypeView->shouldSubmitImplicitly(evt)) {
     // FIXME: Remove type check.
     if (type() == InputTypeNames::search) {
       TaskRunnerHelper::get(TaskType::UserInteraction, &document())
           ->postTask(BLINK_FROM_HERE, WTF::bind(&HTMLInputElement::onSearch,
                                                 wrapPersistent(this)));
     }
     // Form submission finishes editing, just as loss of focus does.
     // If there was a change, send the event now.
-    if (wasChangedSinceLastFormControlChangeEvent())
-      dispatchFormControlChangeEvent();
+    dispatchFormControlChangeEvent();
 
     HTMLFormElement* formForSubmission = m_inputTypeView->formForSubmission();
     // Form may never have been present, or may have been destroyed by code
     // responding to the change event.
     if (formForSubmission)
       formForSubmission->submitImplicitly(evt, canTriggerImplicitSubmission());
-
-    // We treat implicit submission is something like blur()-then-focus(). So
-    // we reset the last value. crbug.com/695349 and crbug.com/700842.
-    setTextAsOfLastFormControlChangeEvent(value());
-
     evt->setDefaultHandled();
     return;
   }
 
   if (evt->isBeforeTextInsertedEvent())
     m_inputTypeView->handleBeforeTextInsertedEvent(
         static_cast<BeforeTextInsertedEvent*>(evt));
 
   if (evt->isMouseEvent() && evt->type() == EventTypeNames::mousedown) {
     m_inputTypeView->handleMouseDownEvent(toMouseEvent(evt));
@@ skipping 597 matching lines @@
 
 bool HTMLInputElement::hasFallbackContent() const {
   return m_inputTypeView->hasFallbackContent();
 }
 
 void HTMLInputElement::setFilesFromPaths(const Vector<String>& paths) {
   return m_inputType->setFilesFromPaths(paths);
 }
 
 }  // namespace blink