MD Settings: Google Play Store: Add subpage and polish (Take 2)

MD Settings: Google Play Store: Add subpage and polish (Take 2)

See issue for screenshots and details.

Originally landed in https://codereview.chromium.org/2785013003/
Reverted due to browser_test debug build assertiion.

BUG=698463
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2796783005
Cr-Commit-Position: refs/heads/master@{#462143}
Committed: https://chromium.googlesource.com/chromium/src/+/385710b054844844e583ce48175d2580d16bffd7

[stevenjb, 2017-04-04 23:11:23]

Description was changed from

==========
MD Settings: Google Play Store: Add subpage and polish (Take 2)

See issue for screenshots and details.

Originally landed in https://codereview.chromium.org/2785013003/
Reverted due to browser_test debug build assertiion.

BUG=698463
==========

to

==========
MD Settings: Google Play Store: Add subpage and polish (Take 2)

See issue for screenshots and details.

Originally landed in https://codereview.chromium.org/2785013003/
Reverted due to browser_test debug build assertiion.

BUG=698463
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-04-04 23:15:53]

Patchset #2 (id:20001) has been deleted

[stevenjb, 2017-04-04 23:18:31]

stevenjb@chromium.org changed reviewers:
+ dbeam@chromium.org

[stevenjb, 2017-04-04 23:18:36]

The CQ bit was checked by stevenjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 23:19:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-04-04 23:23:34]

still lgtm

https://codereview.chromium.org/2796783005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/android_apps_page/android_apps_page.html
(right):

https://codereview.chromium.org/2796783005/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/android_apps_page/android_apps_page.html:26:
inner-h-t-m-l="[[i18n('androidAppsSubtext')]]">
can we make this

$i18nRaw{androidAppsSubtext}

instead?

https://codereview.chromium.org/2796783005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/android_apps_page/android_apps_page.js
(right):

https://codereview.chromium.org/2796783005/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/android_apps_page/android_apps_page.js:61:
settings.navigateTo(settings.Route.ANDROID_APPS_DETAILS);
nit:

  if (this.androidAppsInfo_.appReady)
    settings.navigateTo(settings.Route.ANDROID_APPS_DETAILS);

[commit-bot: I haz the power, 2017-04-05 01:03:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 01:03:57]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2017-04-05 16:43:23]

https://codereview.chromium.org/2796783005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/android_apps_page/android_apps_page.html
(right):

https://codereview.chromium.org/2796783005/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/android_apps_page/android_apps_page.html:26:
inner-h-t-m-l="[[i18n('androidAppsSubtext')]]">
On 2017/04/04 23:23:33, Dan Beam wrote:
> can we make this
> 
> $i18nRaw{androidAppsSubtext}
> 
> instead?

$i18n[Raw] doesn't work with inner-h-t-m-l. If we fixed it there are at least
(but maybe only) two places we could use it including here.

https://codereview.chromium.org/2796783005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/android_apps_page/android_apps_page.js
(right):

https://codereview.chromium.org/2796783005/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/android_apps_page/android_apps_page.js:61:
settings.navigateTo(settings.Route.ANDROID_APPS_DETAILS);
On 2017/04/04 23:23:34, Dan Beam wrote:
> nit:
> 
>   if (this.androidAppsInfo_.appReady)
>     settings.navigateTo(settings.Route.ANDROID_APPS_DETAILS);

Done.

[stevenjb, 2017-04-05 16:43:26]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-04-05 16:43:26]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2796783005/#ps60001
(title: "nit")

[commit-bot: I haz the power, 2017-04-05 16:44:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 18:04:46]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491410606680340,
"parent_rev": "e68cc4a0cef3f755dcebcb1cad23560a10c34f7f", "commit_rev":
"385710b054844844e583ce48175d2580d16bffd7"}

[commit-bot: I haz the power, 2017-04-05 18:05:31]

Description was changed from

==========
MD Settings: Google Play Store: Add subpage and polish (Take 2)

See issue for screenshots and details.

Originally landed in https://codereview.chromium.org/2785013003/
Reverted due to browser_test debug build assertiion.

BUG=698463
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Google Play Store: Add subpage and polish (Take 2)

See issue for screenshots and details.

Originally landed in https://codereview.chromium.org/2785013003/
Reverted due to browser_test debug build assertiion.

BUG=698463
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2796783005
Cr-Commit-Position: refs/heads/master@{#462143}
Committed:
https://chromium.googlesource.com/chromium/src/+/385710b054844844e583ce48175d...
==========

[commit-bot: I haz the power, 2017-04-05 18:05:32]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/385710b054844844e583ce48175d...

[Dan Beam, 2017-04-05 19:27:19]

https://codereview.chromium.org/2796783005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/android_apps_page/android_apps_page.html
(right):

https://codereview.chromium.org/2796783005/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/android_apps_page/android_apps_page.html:26:
inner-h-t-m-l="[[i18n('androidAppsSubtext')]]">
On 2017/04/05 16:43:23, stevenjb wrote:
> On 2017/04/04 23:23:33, Dan Beam wrote:
> > can we make this
> > 
> > $i18nRaw{androidAppsSubtext}
> > 
> > instead?
> 
> $i18n[Raw] doesn't work with inner-h-t-m-l. If we fixed it there are at least
> (but maybe only) two places we could use it including here.

<div class="secondary" id="secondaryText">
  $i18nRaw{androidAppsSubtext}
</div>

[stevenjb, 2017-04-05 19:29:24]

https://codereview.chromium.org/2796783005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/android_apps_page/android_apps_page.html
(right):

https://codereview.chromium.org/2796783005/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/android_apps_page/android_apps_page.html:26:
inner-h-t-m-l="[[i18n('androidAppsSubtext')]]">
On 2017/04/05 19:27:19, Dan Beam wrote:
> On 2017/04/05 16:43:23, stevenjb wrote:
> > On 2017/04/04 23:23:33, Dan Beam wrote:
> > > can we make this
> > > 
> > > $i18nRaw{androidAppsSubtext}
> > > 
> > > instead?
> > 
> > $i18n[Raw] doesn't work with inner-h-t-m-l. If we fixed it there are at
least
> > (but maybe only) two places we could use it including here.
> 
> <div class="secondary" id="secondaryText">
>   $i18nRaw{androidAppsSubtext}
> </div>

Oh, I didn't realize we could embed html that way, although in hindsight that
makes total sense. I'll keep that in mind when we invariably iterate on the
messaging. Thanks!